Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Refactor some sql planning code into functions #4785

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 1, 2023

Draft as it builds on #4779

Which issue does this PR close?

re #4065

Rationale for this change

I am trying to make the code in sql_expr_to_logical_expr as uniform as possible to avoid reintroducing issues like #4065

What changes are included in this PR?

Extract a few more functions

Are these changes tested?

Existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Jan 1, 2023
@alamb alamb force-pushed the alamb/parser_cleanup branch from 80b37d3 to 6403370 Compare January 1, 2023 13:42
@github-actions github-actions bot removed the core Core DataFusion crate label Jan 1, 2023
@alamb alamb marked this pull request as ready for review January 1, 2023 13:42
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job to me

@alamb alamb merged commit 00a22cb into apache:master Jan 2, 2023
@ursabot
Copy link

ursabot commented Jan 2, 2023

Benchmark runs are scheduled for baseline = ad96d41 and contender = 00a22cb. 00a22cb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/parser_cleanup branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants