GH-36642: [Python][CI] Configure warnings as errors during pytest #37018

danepitkin · 2023-08-03T22:25:00Z

Rationale for this change

Warnings are constantly being introduced into the pyarrow tests. Let's try enforcing them as errors in an effort to keep the codebase healthy.

What changes are included in this PR?

Fixed existing warnings
Set warnings as errors in CI

Are these changes tested?

Yes, ran pytests locally w/o warnings.

Are there any user-facing changes?

No

github-actions · 2023-08-03T22:25:28Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

danepitkin · 2023-08-03T22:26:17Z

I enabled warnings as errors for conda python 3.8 through 3.11 and for conda python pandas integration to see what happens. Realistically, we probably want to limit warnings to just the latest python version (currently 3.11).

danepitkin · 2023-08-03T22:30:57Z

@github-actions crossbow submit test-conda-python*

github-actions · 2023-08-03T22:33:48Z

Revision: 9195826

Submitted crossbow builds: ursacomputing/crossbow @ actions-1e510b906c

Task	Status
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.4.1
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.4.1
test-conda-python-3.9
test-conda-python-3.9-pandas-latest

danepitkin · 2023-08-03T22:48:31Z

For python 3.8 through 3.11 there is only 1 warning (repeated in 5 test cases).

____________________ ERROR at setup of test_read_s3fs[True] ____________________
___________________ ERROR at setup of test_read_s3fs[False] ____________________
_______________ ERROR at setup of test_read_directory_s3fs[True] _______________
______________ ERROR at setup of test_read_directory_s3fs[False] _______________
__________ ERROR at setup of test_write_metadata_fs_file_combinations __________

cls = <class '_pytest.runner.CallInfo'>
func = <function call_runtest_hook.<locals>.<lambda> at 0x7fd5884620f0>
when = 'setup'
reraise = (<class '_pytest.outcomes.Exit'>, <class 'KeyboardInterrupt'>)

    @classmethod
    def from_call(
        cls,
        func: "Callable[[], TResult]",
        when: "Literal['collect', 'setup', 'call', 'teardown']",
        reraise: Optional[
            Union[Type[BaseException], Tuple[Type[BaseException], ...]]
        ] = None,
    ) -> "CallInfo[TResult]":
        """Call func, wrapping the result in a CallInfo.
    
        :param func:
            The function to call. Called without arguments.
        :param when:
            The phase in which the function is called.
        :param reraise:
            Exception or exceptions that shall propagate if raised by the
            function, instead of being wrapped in the CallInfo.
        """
        excinfo = None
        start = timing.time()
        precise_start = timing.perf_counter()
        try:
>           result: Optional[TResult] = func()

opt/conda/envs/arrow/lib/python3.9/site-packages/_pytest/runner.py:341: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
opt/conda/envs/arrow/lib/python3.9/site-packages/_pytest/runner.py:262: in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
opt/conda/envs/arrow/lib/python3.9/site-packages/pluggy/_hooks.py:433: in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
opt/conda/envs/arrow/lib/python3.9/site-packages/pluggy/_manager.py:112: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
opt/conda/envs/arrow/lib/python3.9/site-packages/_pytest/unraisableexception.py:83: in pytest_runtest_setup
    yield from unraisable_exception_runtest_hook()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    def unraisable_exception_runtest_hook() -> Generator[None, None, None]:
        with catch_unraisable_exception() as cm:
            yield
            if cm.unraisable:
                if cm.unraisable.err_msg is not None:
                    err_msg = cm.unraisable.err_msg
                else:
                    err_msg = "Exception ignored in"
                msg = f"{err_msg}: {cm.unraisable.object!r}\n\n"
                msg += "".join(
                    traceback.format_exception(
                        cm.unraisable.exc_type,
                        cm.unraisable.exc_value,
                        cm.unraisable.exc_traceback,
                    )
                )
>               warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E               pytest.PytestUnraisableExceptionWarning: Exception ignored in: <socket.socket fd=-1, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6>
E               
E               Traceback (most recent call last):
E                 File "/opt/conda/envs/arrow/lib/python3.9/site-packages/_pytest/fixtures.py", line 902, in call_fixture_func
E                   fixture_result = fixturefunc(**kwargs)
E               ResourceWarning: unclosed <socket.socket fd=189, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 35258), raddr=('127.0.0.1', 56633)>

opt/conda/envs/arrow/lib/python3.9/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning

…cy versions

danepitkin · 2023-08-03T23:11:29Z

@github-actions crossbow submit test-conda-python*

github-actions · 2023-08-03T23:14:42Z

Revision: 6db95f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-2a9b540c67

Task	Status
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.4.1
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.4.1
test-conda-python-3.9
test-conda-python-3.9-pandas-latest

danepitkin · 2023-08-04T19:05:48Z

@github-actions crossbow submit test-conda-python*

github-actions · 2023-08-04T19:08:27Z

Revision: fca7663

Submitted crossbow builds: ursacomputing/crossbow @ actions-45800058d0

Task	Status
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.4.1
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.4.1
test-conda-python-3.9
test-conda-python-3.9-pandas-latest

github-actions · 2023-08-04T19:37:11Z

⚠️ GitHub issue #36642 has been automatically assigned in GitHub to PR creator.

kou

+1

BTW, are you interested in taking over #36745 from me...?

danepitkin · 2023-08-07T21:01:13Z

Hey @kou, sure I can take a look!

kou · 2023-08-08T01:54:49Z

Thanks!

conbench-apache-arrow · 2023-08-11T06:49:09Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2b36521.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

…st (apache#37018) ### Rationale for this change Warnings are constantly being introduced into the pyarrow tests. Let's try enforcing them as errors in an effort to keep the codebase healthy. ### What changes are included in this PR? * Fixed existing warnings * Set warnings as errors in CI ### Are these changes tested? Yes, ran pytests locally w/o warnings. ### Are there any user-facing changes? No * Closes: apache#36642 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

apacheGH-36642: [Python][CI] Configure warnings as errors during pytest

827b03c

danepitkin requested review from assignUser, kou and raulcd as code owners August 3, 2023 22:25

github-actions bot added Component: Python awaiting review Awaiting review labels Aug 3, 2023

Remove pytest args for conda-python-substrait

9195826

Don't assume a warning is thrown, since it varies by package/dependen…

6db95f6

…cy versions

danepitkin added 2 commits August 4, 2023 12:12

Fix hypothesis warnings

fb569f8

Fix ResourceWarning

fca7663

danepitkin changed the title ~~WIP: [Python][CI] Configure warnings as errors during pytest~~ GH-36642: [Python][CI] Configure warnings as errors during pytest Aug 4, 2023

kou approved these changes Aug 7, 2023

View reviewed changes

kou merged commit 2b36521 into apache:main Aug 7, 2023

kou removed the awaiting review Awaiting review label Aug 7, 2023

github-actions bot added the awaiting merge Awaiting merge label Aug 7, 2023

jorisvandenbossche mentioned this pull request Aug 8, 2023

[Python] ResourceWarnings raised by s3 related tests #32892

Closed

AlenkaF mentioned this pull request Aug 22, 2023

[Python] Update test_option_class_equality due to CumulativeSumOptions refactor #37303

Closed

raulcd mentioned this pull request Oct 12, 2023

[CI][Python] test-conda-python is failing due to new DeprecationWarning raised on aiohttp #38239

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-36642: [Python][CI] Configure warnings as errors during pytest #37018

GH-36642: [Python][CI] Configure warnings as errors during pytest #37018

danepitkin commented Aug 3, 2023 •

edited by jorisvandenbossche

Loading

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 3, 2023

danepitkin commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 3, 2023

danepitkin commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

kou left a comment

danepitkin commented Aug 7, 2023

kou commented Aug 8, 2023

conbench-apache-arrow bot commented Aug 11, 2023

GH-36642: [Python][CI] Configure warnings as errors during pytest #37018

GH-36642: [Python][CI] Configure warnings as errors during pytest #37018

Conversation

danepitkin commented Aug 3, 2023 • edited by jorisvandenbossche Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 3, 2023

danepitkin commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 3, 2023

danepitkin commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

danepitkin commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

kou left a comment

Choose a reason for hiding this comment

danepitkin commented Aug 7, 2023

kou commented Aug 8, 2023

conbench-apache-arrow bot commented Aug 11, 2023

danepitkin commented Aug 3, 2023 •

edited by jorisvandenbossche

Loading