Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][CI] Configure warnings as errors during build/test #36642

Closed
danepitkin opened this issue Jul 12, 2023 · 0 comments · Fixed by #37018
Closed

[Python][CI] Configure warnings as errors during build/test #36642

danepitkin opened this issue Jul 12, 2023 · 0 comments · Fixed by #37018

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

Warnings are continuously being introduced into the pyarrow tests. Let's enforce warnings as errors in at least one CI build (probably one that covers latest versions of python/dependencies).

Component(s)

Python

@danepitkin danepitkin added this to the 14.0.0 milestone Jul 12, 2023
@danepitkin danepitkin changed the title [Python] Configure warnings as errors during build/test [Python][CI] Configure warnings as errors during build/test Aug 3, 2023
@kou kou closed this as completed in #37018 Aug 7, 2023
kou pushed a commit that referenced this issue Aug 7, 2023
…7018)

### Rationale for this change

Warnings are constantly being introduced into the pyarrow tests. Let's try enforcing them as errors in an effort to keep the codebase healthy.

### What changes are included in this PR?

* Fixed existing warnings
* Set warnings as errors in CI

### Are these changes tested?

Yes, ran pytests locally w/o warnings.

### Are there any user-facing changes?

No
* Closes: #36642

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…st (apache#37018)

### Rationale for this change

Warnings are constantly being introduced into the pyarrow tests. Let's try enforcing them as errors in an effort to keep the codebase healthy.

### What changes are included in this PR?

* Fixed existing warnings
* Set warnings as errors in CI

### Are these changes tested?

Yes, ran pytests locally w/o warnings.

### Are there any user-facing changes?

No
* Closes: apache#36642

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant