Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Update test_option_class_equality due to CumulativeSumOptions refactor #37303

Closed
AlenkaF opened this issue Aug 22, 2023 · 0 comments · Fixed by #37305
Closed

[Python] Update test_option_class_equality due to CumulativeSumOptions refactor #37303

AlenkaF opened this issue Aug 22, 2023 · 0 comments · Fixed by #37305

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Aug 22, 2023

Describe the bug, including details regarding any error messages, version, and platform.

With #36977 an independent CumulativeSumOptions class has been created that gives a deprecation warning. We have also recently configured warnings as errors during pytest on CI in #37018 so this causes a failure in the CI builds https://github.com/ursacomputing/crossbow/actions/runs/5937030278/job/16098639593.

The test_option_class_equality from test_compute.py needs to be corrected accordingly.

Component(s)

Python

@AlenkaF AlenkaF self-assigned this Aug 22, 2023
jorisvandenbossche pushed a commit that referenced this issue Aug 23, 2023
…eSumOptions refactor (#37305)

### Rationale for this change

Merging of #36977 caused a CI failure due to a test giving a warning.

### What changes are included in this PR?

Add a `filterwarnings` mark to the failing tests. This also tests the deprecation message.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #37303

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche added this to the 14.0.0 milestone Aug 23, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…ulativeSumOptions refactor (apache#37305)

### Rationale for this change

Merging of apache#36977 caused a CI failure due to a test giving a warning.

### What changes are included in this PR?

Add a `filterwarnings` mark to the failing tests. This also tests the deprecation message.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37303

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants