Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [Go] Add arrow.ListLikeType interface #35885

Merged
merged 1 commit into from
Jun 2, 2023
Merged

MINOR: [Go] Add arrow.ListLikeType interface #35885

merged 1 commit into from
Jun 2, 2023

Conversation

candiduslynx
Copy link
Contributor

Rationale for this change

Add arrow.ListLikeType interface corresponding to array.ListLike implementations.

What changes are included in this PR?

  1. Added arrow.ListLikeType
  2. Some receivers changed from value to pointer (per Go recommendation to have either one of them, but not both)

Are these changes tested?

No (per it mainly being the interface addition)

Are there any user-facing changes?

  1. Added arrow.ListLikeType
  2. Some receivers changed from value to pointer (per Go recommendation to have either one of them, but not both)

@candiduslynx candiduslynx requested a review from zeroshade as a code owner June 2, 2023 07:19
@zeroshade zeroshade merged commit fb0c72c into apache:main Jun 2, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 2, 2023
@candiduslynx candiduslynx deleted the feat/listliketype branch June 2, 2023 15:51
@candiduslynx candiduslynx mentioned this pull request Jun 2, 2023
Merged
kodiakhq bot pushed a commit to cloudquery/filetypes that referenced this pull request Jun 2, 2023
@candiduslynx
chore(arrow): Simplify with arrow.ListLikeType (#186)
5553242 
Follow-up after apache/arrow#35885
@candiduslynx candiduslynx mentioned this pull request Jun 2, 2023
Merged
zeroshade pushed a commit that referenced this pull request Jun 2, 2023
@candiduslynx
MINOR: [Go] Use arrow.ListLikeType (#35893)
5a55fb4 
### Rationale for this change

Follow-up for #35885

### What changes are included in this PR?

Removed `listLikeType` interface from `ipc.go` & swapped it for `arrow.ListLikeType`.

### Are these changes tested?

It's only a replace of the interface name.

### Are there any user-facing changes?

No.

Authored-by: candiduslynx <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
@ursabot
Copy link

ursabot commented Jun 3, 2023

Benchmark runs are scheduled for baseline = cd42895 and contender = fb0c72c. fb0c72c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.79% ⬆️0.09%] test-mac-arm
[Failed] ursa-i9-9960x
[Finished ⬇️0.12% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fb0c72c0 ec2-t3-xlarge-us-east-2
[Finished] fb0c72c0 test-mac-arm
[Failed] fb0c72c0 ursa-i9-9960x
[Finished] fb0c72c0 ursa-thinkcentre-m75q
[Finished] cd42895a ec2-t3-xlarge-us-east-2
[Finished] cd42895a test-mac-arm
[Failed] cd42895a ursa-i9-9960x
[Finished] cd42895a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@candiduslynx candiduslynx mentioned this pull request Jun 4, 2023
Merged
zeroshade pushed a commit that referenced this pull request Jun 6, 2023
@candiduslynx
GH-35909: [Go] Deprecate arrow.MapType.ValueField & `arrow.MapType.…
daacbcc 
…ValueType` methods (#35899)

### Rationale for this change

Follow-up for #35885 

### What changes are included in this PR?

* Added `ElemField() Field` to `arrow.ListLikeType` interface
* Added `ElemField() Field` to `arrow.MapType` implementation
* Added deprecation notice to `arrow.MapType.ValueField` & `arrow.MapType.ValueType`
* Fixed a bug in `go/arrow/array/map.go` (`NewMapBuilderWithType` used `ValueType` instead of `ItemType`)

### Are these changes tested?

Compile-time assertion for corresponding types.

### Are there any user-facing changes?

* Added `ElemField() Field` to `arrow.ListLikeType` interface
* Added `ElemField() Field` to `arrow.MapType` implementation
* Added deprecation notice to `arrow.MapType.ValueField` & `arrow.MapType.ValueType`

* Closes: #35909

Authored-by: candiduslynx <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@candiduslynx @ursabot @zeroshade