Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Go] Use arrow.ListLikeType #35893

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

candiduslynx
Copy link
Contributor

Rationale for this change

Follow-up for #35885

What changes are included in this PR?

Removed listLikeType interface from ipc.go & swapped it for arrow.ListLikeType.

Are these changes tested?

It's only a replace of the interface name.

Are there any user-facing changes?

No.

@zeroshade zeroshade merged commit 5a55fb4 into apache:main Jun 2, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 2, 2023
@candiduslynx candiduslynx deleted the chore/use-arrow-listliketype branch June 3, 2023 03:02
@ursabot
Copy link

ursabot commented Jun 3, 2023

Benchmark runs are scheduled for baseline = fb0c72c and contender = 5a55fb4. 5a55fb4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.68% ⬆️0.0%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5a55fb4f ec2-t3-xlarge-us-east-2
[Finished] 5a55fb4f test-mac-arm
[Failed] 5a55fb4f ursa-i9-9960x
[Failed] 5a55fb4f ursa-thinkcentre-m75q
[Finished] fb0c72c0 ec2-t3-xlarge-us-east-2
[Finished] fb0c72c0 test-mac-arm
[Failed] fb0c72c0 ursa-i9-9960x
[Finished] fb0c72c0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

dgreiss added a commit to dgreiss/arrow that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants