-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35909: [Go] Deprecate arrow.MapType.ValueField
& arrow.MapType.ValueType
methods
#35899
Conversation
@zeroshade I've marked the |
ElemField() Field
to arrow.ListLikeType
interfacearrow.MapType.ValueField
& arrow.MapType.ValueType
methods
|
@zeroshade any chance to get an initial review today? |
f8b4420
to
9fb8a8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one nit
Benchmark runs are scheduled for baseline = 77d8bc5 and contender = daacbcc. daacbcc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
Follow-up for #35885
What changes are included in this PR?
ElemField() Field
toarrow.ListLikeType
interfaceElemField() Field
toarrow.MapType
implementationarrow.MapType.ValueField
&arrow.MapType.ValueType
go/arrow/array/map.go
(NewMapBuilderWithType
usedValueType
instead ofItemType
)Are these changes tested?
Compile-time assertion for corresponding types.
Are there any user-facing changes?
ElemField() Field
toarrow.ListLikeType
interfaceElemField() Field
toarrow.MapType
implementationarrow.MapType.ValueField
&arrow.MapType.ValueType
arrow.MapType.ValueField
&arrow.MapType.ValueType
methods #35909