-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17385: [Integration] Re-enable Rust integration case #13852
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lidavidm -- I looked at the integration run https://github.com/apache/arrow/runs/7785878022?check_suite_focus=true and it definitely passes (though I didn't see anything explicitly in the logs about having run the scenario!)
Is there any reason to hold off merging this PR @lidavidm ? I ask because of the somewhat scary sounding commit message |
Look for "C++ serving, Rust requesting" then scroll down to see "Testing file middleware" - on master it says
Should be good, I just put that initially in case it did fail 😅 |
🚀 thanks @lidavidm and @carols10cents ! |
…huh, the new merge script uses the original commit and NOT the PR title like I would have expected. |
If there's only one commit in the PR, the GitHub PR merge API will use the commit message and not the PR title (by default). |
That's a little unfortunate :( I'll have to be more careful about commit messages |
We can probably fix this going forward in the merge script, though this specific commit message should get amended. |
Hmm, is this worth force-pushing? I guess it hasn't been very long |
Or we can revert and push again |
…13856) This reverts commit e2efc87 (#13852) since it ended up with the wrong commit message. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Benchmark runs are scheduled for baseline = b7c94e2 and contender = e2efc87. e2efc87 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
I am sorry @lidavidm -- I think I got too excited about this improvement and just hit the Enticing green button. I should have reviewed the dev process again. 😞 Thanks for cleaning up my mess |
Ah, whoops! Well from Zulip apparently there's a setting we can ask Infra to toggle to also make that work, fortunately |
I double checked and it seems like master has the change reverted (but not yet re-changed) https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/runner.py#L433 Would it be helpful for me to to prepare a new PR with the change (revert the revert?) |
I put one up here already: #13858 Just haven't run the merge script yet |
…13858) Redo the PR since the original ended up with the wrong commit message. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
And now it should be all good |
Thanks again @lidavidm and sorry about that |
) (apache#13858) Redo the PR since the original ended up with the wrong commit message. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
) (apache#13858) Redo the PR since the original ended up with the wrong commit message. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Follow up for ARROW-10961 (apache/arrow-rs#140).
Closes apache/arrow-rs#140