Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Upgrade to tonic > 0.3.1 to get fix of headers/trailers handling #140

Closed
alamb opened this issue Apr 26, 2021 · 7 comments · Fixed by apache/arrow#13852
Closed
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-10961

C++ gRPC servers sometimes return both headers and trailers, and [tonic|https://crates.io/crates/tonic], the crate that provides a Rust gRPC implementation, wasn't correctly merging headers and trailers for errors in the gRPC client. [This has been fixed|https://github.com/hyperium/tonic/pull/510] and should be included in the next release of tonic, which should have some version number greater than 0.3.1, but I'm not sure what tonic's release plans are.

In the Rust Flight integration test client I'm developing, the middleware scenario with the Rust client against the C++ server will fail until this is taken care of. Filing this ticket so I can reference it in the disabling of that test case.

@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@lidavidm
Copy link
Member

lidavidm commented Aug 9, 2022

FWIW, I happened to see this. It looks like we're on tonic 0.8 now - so maybe this can be re-enabled?

@alamb
Copy link
Contributor Author

alamb commented Aug 10, 2022

I agree -- @carols10cents since it appears you filed the original issue, do you remember which integration scenario you were referring to in the original ticket?

@lidavidm
Copy link
Member

Sorry, should've linked it: https://github.com/apache/arrow/blob/74f221c925688a1fab05c0394818256d816ccfc1/dev/archery/archery/integration/runner.py#L430-L434

I saw it while poking around the tests

@carols10cents
Copy link
Contributor

I agree -- @carols10cents since it appears you filed the original issue, do you remember which integration scenario you were referring to in the original ticket?

Sorry, I have trouble remembering last week sometimes, let alone December 2020 😅

@lidavidm
Copy link
Member

I linked it above - I can just re-enable it and see what happens, and if it works we can close this out?

@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2022

I linked it above - I can just re-enable it and see what happens, and if it works we can close this out?

That would be awesome @lidavidm -- thank you very much!

@lidavidm
Copy link
Member

Looks like it passes fine: apache/arrow#13852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants