Skip to content

Commit

Permalink
MINOR: [C++] Add check for result of MakeExecNode (#13849)
Browse files Browse the repository at this point in the history
ARROW-16894 added benchmarks for asof join node. This PR adds a call to `ASSERT_OK` to satisfy the warning that the `Result` returned by `MakeExecNode` was not checked.

Authored-by: Aldrin M <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
  • Loading branch information
drin authored Aug 11, 2022
1 parent cdb5b20 commit b7c94e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/src/arrow/compute/exec/asof_join_benchmark.cc
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ static void TableJoinOverhead(benchmark::State& state,
ASSERT_OK_AND_ASSIGN(arrow::compute::ExecNode * join_node,
MakeExecNode(factory_name, plan.get(), input_nodes, options));
AsyncGenerator<util::optional<ExecBatch>> sink_gen;
MakeExecNode("sink", plan.get(), {join_node}, SinkNodeOptions{&sink_gen});
ASSERT_OK(MakeExecNode("sink", plan.get(), {join_node}, SinkNodeOptions{&sink_gen}));
state.ResumeTiming();
ASSERT_FINISHES_OK(StartAndCollect(plan.get(), sink_gen));
}
Expand Down

0 comments on commit b7c94e2

Please sign in to comment.