-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16636: [Rust] Activate several IPC integration tests for rust #13219
Conversation
|
|
cc @alamb |
Got the following errors in CI:
Hmm, I ran |
This is epic -- thank you @viirya for looking into this |
I'm in business trip this week. I will have more time to look into this in next week. |
Regarding the failure I propose a quick fix at Rust side to remove it, just following C++ Arrow decimal builder. |
Yea, |
For |
@alamb All tests are passed now. Please take a look. Thanks. |
Amazing work @viirya ❤️ |
The arrow repo used to have a different way of merging PRs (using a script) -- let me know if you would like to give it a try or if you would like me to. 🎖️ |
@alamb Thank you. I may rarely touch C++ repo. Please help merging this. If I have more works in this repo in the future, I can catch up it later. |
Looking into it |
Following the process in https://github.com/apache/arrow/tree/master/dev |
Thanks again @viirya -- this is a major step forward |
Thank you @alamb |
arrow-rs has fixed severals integration test failures (apache/arrow-rs#1404):
generate_decimal128_case
generate_interval_case
generate_map_case
generate_non_canonical_map_case
generate_nested_large_offsets_case
generate_nested_dictionary_case
generate_unions_case
And this one passes test without any fix:
generate_extension_case
We should activate these IPC integration tests for rust.