Remove validate_decimal_precision
check in DecimalBuilder.append_value
#1766
Labels
development-process
Related to development process of arrow-rs
enhancement
Any new improvement worthy of a entry in the changelog
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is one issue found by enabling
generate_decimal128_case
integration case at C++ repo (apache/arrow#13219).This crate validates precision of decimal by
validate_decimal_precision
in few places, e.g.DecimalBuilder
'sappend_value
. However, in decimal golden file0.14.1_decimal.gold.json
, there are some values failing this check. C++ doesn't perform similar check as I did a search (e.g. Decimal128Builder, DecimalFromString), and I can confirm that test case can be passed if I removevalidate_decimal_precision
check inappend_value
.I'm wondering if we should remove the check to pass the test case? Or leaving
generate_decimal128_case
as skipped test case at the integration test?Actually in C++, similar check is done when doing a full validating ArrayData: https://github.com/apache/arrow/blob/c715bebbd89089f385c9996560866da23ea1ddda/cpp/src/arrow/array/validate.cc#L672. We may move the check to validating ArrayData too.
Describe the solution you'd like
Remove
validate_decimal_precision
check inDecimalBuilder
'sappend_value
to pass the integration test casegenerate_decimal128_case
.Describe alternatives you've considered
Keep
generate_decimal128_case
as skipped test caseAdditional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: