-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and skip validity buffer of UnionType Array for V4 ipc message #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 83.39% 83.39% -0.01%
==========================================
Files 198 198
Lines 56171 56205 +34
==========================================
+ Hits 46846 46872 +26
- Misses 9325 9333 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need to do anything for write support?
Thanks @nevi-me Yes, if specifying I will create another PR after this for writer change and test. |
@@ -201,6 +206,13 @@ fn create_array( | |||
|
|||
let len = union_node.length() as usize; | |||
|
|||
// In V4, union types has validity bitmap | |||
// In V5 and later, union types have no validity bitmap | |||
if metadata < &ipc::MetadataVersion::V5 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Which issue does this PR close?
Closes #1788.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?