Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][MATLAB][Packaging] Add support for MATLAB R2024a in CI and crossbow packaging workflows #41385

Closed
kevingurney opened this issue Apr 25, 2024 · 1 comment

Comments

@kevingurney
Copy link
Member

Describe the enhancement requested

MATLAB R2024a is the latest available version of MATLAB as of April 2024.

We are currently building against MATLAB R2023a in CI and for the crossbow packaging workflow.

We should update the version of MATLAB we support to the latest available version.

We previously created an issue to use R2023b (#37809). However, R2024a has become publicly available since then.

We may want to consider building and packaging against multiple versions of MATLAB in parallel, rather than just the latest. This would require some more thought on how many releases back to support over time, however.

Component(s)

Continuous Integration, MATLAB, Packaging

@kevingurney kevingurney changed the title [CI][MATLAB][Packaging] Add support for MATLAB R2024a in CI and crossbow packaging workflows [CI][MATLAB][Packaging] Add support for MATLAB R2024a in CI and crossbow packaging workflows Apr 25, 2024
kevingurney added a commit that referenced this issue Apr 25, 2024
…os-latest` change to `macos-14` (#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  #41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: #41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
raulcd pushed a commit that referenced this issue Apr 29, 2024
…os-latest` change to `macos-14` (#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  #41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: #41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
sgilmore10 added a commit that referenced this issue Apr 30, 2024
…1436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- #41435
- #41385

* GitHub Issue: #41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
@sgilmore10 sgilmore10 self-assigned this May 1, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…6` (apache#41436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- apache#41435
- apache#41385

* GitHub Issue: apache#41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
sgilmore10 added a commit that referenced this issue May 3, 2024
…CI and crossbow packaging workflows (#41504)

### Rationale for this change

MATLAB `R2024a` is the latest available version of MATLAB as of April 2024.

We are currently building against MATLAB `R2023a` in CI and for the crossbow packaging workflow.

We should update the version of MATLAB we support to the latest available version.

We previously created an issue to use `R2023b` (#37809). However, `R2024a` has become publicly available since then.

### What changes are included in this PR?

1. Changed the `release` argument supplied to `matlab-actions/setup-matlab@ v2` to `R2024a` from `R2023a` in `.github/workflows/matlab.yml` and `dev/tasks/matlab/github.yml`.

2. Updated the script used to package the MLTBX file (`arrow/matlab/tools/packageMatlabInterface.m`) to specify the version of MATLAB currently running as the only compatible version of MATLAB for the interface. 

3.  Updated display tests to react to a change in how class names are formatted when an objected is displayed in the Command Window.

### Are these changes tested?

Yes. Existing tests used.

### Are there any user-facing changes?

There are no changes to the MATLAB Arrow Interface. However, the MATLAB release used to build, test, and package the interface has been upgraded.

### Future Work

1. We may want to consider building and packaging against multiple versions of MATLAB in parallel, rather than just the latest. This would require some more thought on how many releases back to support over time, however.

2. #41435

* GitHub Issue: #41385

Lead-authored-by: Sarah Gilmore <[email protected]>
Co-authored-by: Sarah Gilmore <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
@sgilmore10
Copy link
Member

Issue resolved by pull request 41504
#41504

@sgilmore10 sgilmore10 added this to the 17.0.0 milestone May 3, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…6` (apache#41436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- apache#41435
- apache#41385

* GitHub Issue: apache#41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…a` in CI and crossbow packaging workflows (apache#41504)

### Rationale for this change

MATLAB `R2024a` is the latest available version of MATLAB as of April 2024.

We are currently building against MATLAB `R2023a` in CI and for the crossbow packaging workflow.

We should update the version of MATLAB we support to the latest available version.

We previously created an issue to use `R2023b` (apache#37809). However, `R2024a` has become publicly available since then.

### What changes are included in this PR?

1. Changed the `release` argument supplied to `matlab-actions/setup-matlab@ v2` to `R2024a` from `R2023a` in `.github/workflows/matlab.yml` and `dev/tasks/matlab/github.yml`.

2. Updated the script used to package the MLTBX file (`arrow/matlab/tools/packageMatlabInterface.m`) to specify the version of MATLAB currently running as the only compatible version of MATLAB for the interface. 

3.  Updated display tests to react to a change in how class names are formatted when an objected is displayed in the Command Window.

### Are these changes tested?

Yes. Existing tests used.

### Are there any user-facing changes?

There are no changes to the MATLAB Arrow Interface. However, the MATLAB release used to build, test, and package the interface has been upgraded.

### Future Work

1. We may want to consider building and packaging against multiple versions of MATLAB in parallel, rather than just the latest. This would require some more thought on how many releases back to support over time, however.

2. apache#41435

* GitHub Issue: apache#41385

Lead-authored-by: Sarah Gilmore <[email protected]>
Co-authored-by: Sarah Gilmore <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
CurtHagenlocher pushed a commit to CurtHagenlocher/arrow that referenced this issue Jun 14, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants