Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually pass matlab_add_mex the required MEX libraries (e.g. libmx, libmex, and libMatlabDataArray) #76

Closed
sgilmore10 opened this issue Apr 26, 2024 · 0 comments

Comments

@sgilmore10
Copy link
Contributor

By default, the matlab_add_mex function automatically links the target MEX function against all MATLAB mex-related libraries:

  • libmx
  • libmex
  • libMatlabDataArray
  • libMatlabEngine

However, libMatlabEngine is only required for standalone C++ programs that utilize the MATLAB Engine. This library is not required for C++ MEX functions and linking against it causes run-time errors on macos-14. See this log file for details.

sgilmore10 added a commit to apache/arrow that referenced this issue Apr 30, 2024
…1436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- #41435
- #41385

* GitHub Issue: #41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…6` (apache#41436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- apache#41435
- apache#41385

* GitHub Issue: apache#41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…6` (apache#41436)

### Rationale for this change

@ kevingurney and I recently resolved multiple issues related to `mathworks/libmexclass` not supporting ARM-based macOS builds (i.e. builds on `macos-14`):

- mathworks/libmexclass#76
- mathworks/libmexclass#77

We should bump the version of mathworks/libmexclass used by the MATLAB interface to the latest available commit ([ca3cea6](mathworks/libmexclass@ca3cea6) as of now) in order to enable building the MATLAB interface to Arrow on `macos-14` (which is ARM-based).

### What changes are included in this PR?

- Bumped version of `mathworks/libmexclass` used by the MATLAB interface to [ca3cea6](mathworks/libmexclass@ca3cea6)

### Are these changes tested?

- Yes. The existing test points verify verify upgrading `mathworks/libmexclass` does not break the MATLAB interface.

### Are there any user-facing changes?

- No. 

### Future Directions

- apache#41435
- apache#41385

* GitHub Issue: apache#41400

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant