GH-41385: [CI][MATLAB][Packaging] Add support for MATLAB R2024a in CI and crossbow packaging workflows
#41504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display formatting changes
MATLAB used to create the MLTBX file
|
@github-actions crossbow submit matlab |
|
|
@github-actions crossbow submit matlab |
|
Revision: 4cdfdb9 Submitted crossbow builds: ursacomputing/crossbow @ actions-86458212c1
|
|
Verified the packaged MATLAB Arrow Interface manually by
|
sgilmore10
requested review from
assignUser,
kou,
raulcd and
kevingurney
as code owners
github-actions
bot
added
awaiting merge
Co-authored-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c8cf61c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 29 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…a` in CI and crossbow packaging workflows (apache#41504) ### Rationale for this change MATLAB `R2024a` is the latest available version of MATLAB as of April 2024. We are currently building against MATLAB `R2023a` in CI and for the crossbow packaging workflow. We should update the version of MATLAB we support to the latest available version. We previously created an issue to use `R2023b` (apache#37809). However, `R2024a` has become publicly available since then. ### What changes are included in this PR? 1. Changed the `release` argument supplied to `matlab-actions/setup-matlab@ v2` to `R2024a` from `R2023a` in `.github/workflows/matlab.yml` and `dev/tasks/matlab/github.yml`. 2. Updated the script used to package the MLTBX file (`arrow/matlab/tools/packageMatlabInterface.m`) to specify the version of MATLAB currently running as the only compatible version of MATLAB for the interface. 3. Updated display tests to react to a change in how class names are formatted when an objected is displayed in the Command Window. ### Are these changes tested? Yes. Existing tests used. ### Are there any user-facing changes? There are no changes to the MATLAB Arrow Interface. However, the MATLAB release used to build, test, and package the interface has been upgraded. ### Future Work 1. We may want to consider building and packaging against multiple versions of MATLAB in parallel, rather than just the latest. This would require some more thought on how many releases back to support over time, however. 2. apache#41435 * GitHub Issue: apache#41385 Lead-authored-by: Sarah Gilmore <[email protected]> Co-authored-by: Sarah Gilmore <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sarah Gilmore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
MATLAB
R2024ais the latest available version of MATLAB as of April 2024.We are currently building against MATLAB
R2023ain CI and for the crossbow packaging workflow.We should update the version of MATLAB we support to the latest available version.
We previously created an issue to use
R2023b(#37809). However,R2024ahas become publicly available since then.What changes are included in this PR?
Changed the
releaseargument supplied tomatlab-actions/setup-matlab@v2toR2024afromR2023ain.github/workflows/matlab.ymlanddev/tasks/matlab/github.yml.Updated the script used to package the MLTBX file (
arrow/matlab/tools/packageMatlabInterface.m) to specify the version of MATLAB currently running as the only compatible version of MATLAB for the interface.Updated display tests to react to a change in how class names are formatted when an objected is displayed in the Command Window.
Are these changes tested?
Yes. Existing tests used.
Are there any user-facing changes?
There are no changes to the MATLAB Arrow Interface. However, the MATLAB release used to build, test, and package the interface has been upgraded.
Future Work
We may want to consider building and packaging against multiple versions of MATLAB in parallel, rather than just the latest. This would require some more thought on how many releases back to support over time, however.
[CI][MATLAB] Add job to build and test MATLAB Interface on
macos-14#41435R2024ain CI and crossbow packaging workflows #41385