Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release][Go][macOS] Verification tasks fail on Go parquet encryption tests #38449

Closed
kou opened this issue Oct 25, 2023 · 0 comments · Fixed by #38450
Closed

[Release][Go][macOS] Verification tasks fail on Go parquet encryption tests #38449

kou opened this issue Oct 25, 2023 · 0 comments · Fixed by #38450
Assignees
@kou
Labels
Component: Go Component: Release Type: enhancement
Milestone
14.0.2

Comments

@kou
Copy link
Member

kou commented Oct 25, 2023

Describe the enhancement requested

This is the same problem of #38345 but this is only for macOS.
The fix (#38362) of #38345 works on Linux but doesn't work on macOS.

Component(s)

Go, Release
kou added a commit to kou/arrow that referenced this issue Oct 25, 2023
@kou
apacheGH-38449: [Release][Go][macOS] Use local test data if possible
b8090a6 
On macOS, "cp -a source/ destination/" copies "source/*" to
"destination/" (such as "source/a" is copied to "destination/a") not
"source/" to "destination/" (such as "source/a" is copied to
"destination/source/a").

We need to remove the trailing "/" from "source/" to copy "source/"
itself to "destination/source/".
@github-actions github-actions bot mentioned this issue Oct 25, 2023
Merged
raulcd pushed a commit that referenced this issue Oct 25, 2023
@kou
GH-38449: [Release][Go][macOS] Use local test data if possible (#38450)
25e5d19 
### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 15.0.0 milestone Oct 25, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
@kou @JerAguilon
apacheGH-38449: [Release][Go][macOS] Use local test data if possible (a…
284f55c 
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-38449: [Release][Go][macOS] Use local test data if possible (a…
704e2b6 
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd modified the milestones: 15.0.0, 14.0.2 Dec 12, 2023
raulcd pushed a commit that referenced this issue Dec 12, 2023
@kou @raulcd
GH-38449: [Release][Go][macOS] Use local test data if possible (#38450)
8fc81ce 
### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38449: [Release][Go][macOS] Use local test data if possible (a…
49b5947 
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Go Component: Release Type: enhancement
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-38449: [Release][Go][macOS] Use local test data if possible kou/arrow
2 participants
@kou @raulcd