Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38449: [Release][Go][macOS] Use local test data if possible #38450

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kou
Copy link
Member

@kou kou commented Oct 25, 2023

Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

On macOS, "cp -a source/ destination/" copies "source/*" to
"destination/" (such as "source/a" is copied to "destination/a") not
"source/" to "destination/" (such as "source/a" is copied to
"destination/source/a").

We need to remove the trailing "/" from "source/" to copy "source/"
itself to "destination/source/".
@kou kou requested review from assignUser and raulcd as code owners October 25, 2023 02:05
@github-actions
Copy link

⚠️ GitHub issue #38449 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Oct 25, 2023

@github-actions crossbow submit verify-rc-source-go-* --param release=14.0.0 --param rc=2

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 25, 2023
@github-actions
Copy link

Revision: b8090a6

Submitted crossbow builds: ursacomputing/crossbow @ actions-6a647948aa

Task Status
verify-rc-source-go-linux-almalinux-8-amd64 Github Actions
verify-rc-source-go-linux-conda-latest-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-go-macos-amd64 Github Actions
verify-rc-source-go-macos-arm64 Github Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou !

@raulcd raulcd merged commit 25e5d19 into apache:main Oct 25, 2023
6 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Oct 25, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 25, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 25, 2023
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 25e5d19.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@kou kou deleted the release-verify-rc-go-macos branch December 11, 2023 19:59
raulcd pushed a commit that referenced this pull request Dec 12, 2023
### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#38450)

### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38449

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release][Go][macOS] Verification tasks fail on Go parquet encryption tests
2 participants