GH-38345: [Release] Use local test data for verification if possible #38362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures.
|
|
|
@github-actions crossbow submit verify-rc-source-go-linux-almalinux-8-amd64 --param release=14.0.0 --param rc=2 |
|
Revision: c86902a Submitted crossbow builds: ursacomputing/crossbow @ actions-715f090516
|
assignUser
approved these changes
Oct 20, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 394966b. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…sible (apache#38362) ### Rationale for this change We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures. ### What changes are included in this PR? Use local test data if they exist. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38345 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
@github-actions crossbow submit verify-rc-source-go-* --param release=14.0.0 --param rc=2 |
|
Revision: c86902a Submitted crossbow builds: ursacomputing/crossbow @ actions-4e77f224e9
|
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 25, 2023
…sible (apache#38362) ### Rationale for this change We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures. ### What changes are included in this PR? Use local test data if they exist. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38345 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…sible (apache#38362) ### Rationale for this change We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures. ### What changes are included in this PR? Use local test data if they exist. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38345 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
Dec 6, 2023
…38362) ### Rationale for this change We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures. ### What changes are included in this PR? Use local test data if they exist. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38345 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…sible (apache#38362) ### Rationale for this change We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures. ### What changes are included in this PR? Use local test data if they exist. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38345 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We have external test data repositories, apache/arrow-testing and apache/parquet-testing. We use them as submodule. apache/arrow may not use the latest test data repositories. But our verification script always use the latest test data repositories. It may cause test failures.
What changes are included in this PR?
Use local test data if they exist.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.