Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some clippy errors after updating rust toolchain #3010

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Fix some clippy errors after updating rust toolchain #3010

merged 3 commits into from
Nov 3, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 3, 2022 •
edited
Loading

Which issue does this PR close?

Closes #3011.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Nov 3, 2022
viirya
viirya commented Nov 3, 2022
View reviewed changes
arrow-schema/src/field.rs

collected_fields
}

fn _fields<'a>(&'a self, dt: &'a DataType) -> Vec<&Field> {
fn _fields(dt: &DataType) -> Vec<&Field> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: parameter is only used in recursion

viirya
viirya commented Nov 3, 2022
View reviewed changes
arrow/src/ipc/convert.rs
@@ -477,7 +477,6 @@ pub(crate) fn build_field<'a>(
/// Get the IPC type of a data type
pub(crate) fn get_fb_field_type<'a>(
data_type: &DataType,
is_nullable: bool,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: parameter is only used in recursion

@viirya viirya mentioned this pull request Nov 3, 2022
Merged
@viirya
Copy link
Member Author

viirya commented Nov 3, 2022

cc @alamb @tustvold

@viirya viirya merged commit 01ea8c7 into apache:master Nov 3, 2022
@viirya viirya deleted the fix_clippy branch November 3, 2022 22:37
@ursabot
Copy link

ursabot commented Nov 3, 2022

Benchmark runs are scheduled for baseline = 61cf6f7 and contender = 01ea8c7. 01ea8c7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Nov 4, 2022
Merged
@tustvold tustvold added the development-process Related to development process of arrow-rs label Nov 4, 2022
@alamb alamb mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some clippy errors after updating rust toolchain
3 participants
@viirya @ursabot @tustvold