Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check overflow when casting integer to decimal #3009

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Check overflow when casting integer to decimal #3009

merged 6 commits into from
Nov 4, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 3, 2022

Which issue does this PR close?

Part of #2986.

This deals with the case of casting integer to decimal.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 3, 2022
tustvold
tustvold approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the two cast_integer_to_decimal methods could be combined together? 🤔

@viirya
Copy link
Member Author

viirya commented Nov 3, 2022

I wonder if the two cast_integer_to_decimal methods could be combined together? 🤔

It's doable. I combined them in latest commit.

@viirya
Copy link
Member Author

viirya commented Nov 3, 2022

Going to fix clippy errors: #3010

tustvold
tustvold reviewed Nov 4, 2022
View reviewed changes
arrow-array/src/types.rs Outdated
@@ -521,6 +524,10 @@ impl DecimalType for Decimal128Type {
format_decimal_str(&value.to_string(), precision as usize, scale as usize)
}

fn format_decimal_type(precision: u8, scale: u8) -> String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we have handled this in other places is an associated const PREFIX

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to PREFIX way.

@viirya viirya merged commit 766f69f into apache:master Nov 4, 2022
@ursabot
Copy link

ursabot commented Nov 4, 2022

Benchmark runs are scheduled for baseline = 8400b09 and contender = 766f69f. 766f69f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viirya @ursabot @tustvold