Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clippy errors after updating rust toolchain #3011

Closed
viirya opened this issue Nov 3, 2022 · 4 comments · Fixed by #3010 or #3015
Closed

Some clippy errors after updating rust toolchain #3011

viirya opened this issue Nov 3, 2022 · 4 comments · Fixed by #3010 or #3015
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate

Comments

@viirya
Copy link
Member

viirya commented Nov 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

There are some clippy errors after updating rust toolchain, e.g.:

error: parameter is only used in recursion
   --> arrow-schema/src/field.rs:208:24
    |
208 |     fn _fields<'a>(&'a self, dt: &'a DataType) -> Vec<&Field> {
    |                        ^^^^
    |
    = note: `-D clippy::only-used-in-recursion` implied by `-D warnings`
note: parameter used here
   --> arrow-schema/src/field.rs:217:53
    |
217 |             DataType::Dictionary(_, value_field) => self._fields(value_field.as_ref()),
    |                                                     ^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'object-store'} from #3015

@alamb alamb added object-store Object Store Interface parquet Changes to the parquet crate labels Nov 11, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'parquet'} from #3010

@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3010

@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'parquet-derive'} from #3010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
2 participants