Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic support Apache APISIX 2.13.0 #2428

Merged
merged 18 commits into from
May 6, 2022

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Apr 15, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
support Apache APISIX 2.13.0

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #2428 (ef6842f) into master (8bdf8b6) will decrease coverage by 31.43%.
The diff coverage is n/a.

❗ Current head ef6842f differs from pull request most recent head b636f50. Consider uploading reports for the commit b636f50 to get more accurate results

@@             Coverage Diff             @@
##           master    #2428       +/-   ##
===========================================
- Coverage   68.57%   37.14%   -31.44%     
===========================================
  Files         131       58       -73     
  Lines        3421     4036      +615     
  Branches      828        0      -828     
===========================================
- Hits         2346     1499      -847     
- Misses       1075     2253     +1178     
- Partials        0      284      +284     
Flag Coverage Δ
backend-e2e-test 37.14% <ø> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx
web/src/components/Plugin/PluginPage.tsx
web/src/components/Plugin/UI/cors.tsx
web/src/components/Plugin/UI/limit-count.tsx
web/src/components/Plugin/UI/proxy-mirror.tsx
web/src/components/Plugin/data.tsx
...omponents/Upstream/components/ServiceDiscovery.tsx
web/src/pages/Consumer/List.tsx
...pages/Route/components/Step1/RequestConfigView.tsx
web/src/components/Plugin/service.ts
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdf8b6...b636f50. Read the comment docs.

@guoqqqi
Copy link
Member Author

guoqqqi commented Apr 15, 2022

@nic-chen Can you guide me through back-end CI error?

@guoqqqi
Copy link
Member Author

guoqqqi commented Apr 18, 2022

@nic-chen Please help me solve the CI error 😄

@bzp2010
Copy link
Contributor

bzp2010 commented Apr 23, 2022

@guoqqqi By comparing 2.12 with 2.13 code, I noticed these

  • Lack of schema definition for mocking and opentelemetry plugins, we need to check further (We need the full version to compare the two versions)
  • We need to add the corresponding options for the new service discovery option kubernetes.

cc @nic-chen

api/conf/schema.json Outdated Show resolved Hide resolved
api/conf/schema.json Outdated Show resolved Hide resolved
@guoqqqi guoqqqi merged commit bd1f6c1 into apache:master May 6, 2022
@guoqqqi guoqqqi deleted the feat-support-apisix2.13.0 branch May 6, 2022 09:43
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request May 24, 2022
* upstream: (28 commits)
  docs: update some tips in develop.md (apache#2451)
  fix: create upstream error when pass host is node and nodes without port (apache#2421)
  fix: correct data  type of filed Active.checks.active.https_verify_certificate (apache#2422)
  feat: basic support Apache APISIX 2.13.0 (apache#2428)
  feat: add page reload judgment (apache#2370)
  docs: Update RPM install package link (apache#2439)
  docs: Remove hyperlinks from documents (apache#2431)
  chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423)
  fix: consumer without plugins causes page crashes (apache#2437)
  chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420)
  feat: Modify plugin preview page (apache#2359)
  chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418)
  chore: use json schema instead hard code (apache#2399)
  refactor: migrate route tests to e2enew (apache#2411)
  chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414)
  chore: update the year of copyright and fix typo (apache#2417)
  docs: update online playground url (apache#2416)
  chore: update README for online demo (apache#2404)
  refactor: migrate id compatible tests to e2enew (apache#2400)
  docs: fix invalid link (apache#2366)
  ...

# Conflicts:
#	api/internal/route.go
#	web/src/components/Footer/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants