-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modify plugin preview page #2359
feat: Modify plugin preview page #2359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2359 +/- ##
==========================================
+ Coverage 68.12% 68.66% +0.53%
==========================================
Files 127 131 +4
Lines 3379 3427 +48
Branches 832 831 -1
==========================================
+ Hits 2302 2353 +51
+ Misses 1077 1074 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
Show resolved
Hide resolved
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
Show resolved
Hide resolved
Hi, @Si-ege can you add some images for this PR? |
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
Outdated
Show resolved
Hide resolved
also cc @Baoyuantop PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work~
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other LGTM, also cc @hanzhenfang take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM cc @Baoyuantop @SkyeYoung
* upstream: (28 commits) docs: update some tips in develop.md (apache#2451) fix: create upstream error when pass host is node and nodes without port (apache#2421) fix: correct data type of filed Active.checks.active.https_verify_certificate (apache#2422) feat: basic support Apache APISIX 2.13.0 (apache#2428) feat: add page reload judgment (apache#2370) docs: Update RPM install package link (apache#2439) docs: Remove hyperlinks from documents (apache#2431) chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423) fix: consumer without plugins causes page crashes (apache#2437) chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420) feat: Modify plugin preview page (apache#2359) chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418) chore: use json schema instead hard code (apache#2399) refactor: migrate route tests to e2enew (apache#2411) chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414) chore: update the year of copyright and fix typo (apache#2417) docs: update online playground url (apache#2416) chore: update README for online demo (apache#2404) refactor: migrate id compatible tests to e2enew (apache#2400) docs: fix invalid link (apache#2366) ... # Conflicts: # api/internal/route.go # web/src/components/Footer/index.tsx
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #1991
1.The preview page shows only the activated plug-ins.
Checklist: