Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify plugin preview page #2359

Merged
merged 10 commits into from
Apr 17, 2022
Merged

feat: Modify plugin preview page #2359

merged 10 commits into from
Apr 17, 2022

Conversation

Si-ege
Copy link
Contributor

@Si-ege Si-ege commented Mar 3, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #1991
1.The preview page shows only the activated plug-ins.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #2359 (da35f96) into master (abefe97) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2359      +/-   ##
==========================================
+ Coverage   68.12%   68.66%   +0.53%     
==========================================
  Files         127      131       +4     
  Lines        3379     3427      +48     
  Branches      832      831       -1     
==========================================
+ Hits         2302     2353      +51     
+ Misses       1077     1074       -3     
Flag Coverage Δ
frontend-e2e-test 68.66% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginPage.tsx 98.82% <100.00%> (+0.08%) ⬆️
web/src/pages/PluginTemplate/List.tsx 71.42% <0.00%> (-1.08%) ⬇️
web/src/pages/Service/List.tsx 94.11% <0.00%> (-0.76%) ⬇️
web/src/helpers.tsx 73.77% <0.00%> (ø)
web/src/pages/Consumer/Create.tsx 82.69% <0.00%> (ø)
web/src/pages/Consumer/components/Step1.tsx 100.00% <0.00%> (ø)
...b/src/pages/Proto/components/ProtoDrawer/index.tsx 88.46% <0.00%> (ø)
web/src/pages/Proto/List.tsx 96.15% <0.00%> (ø)
web/src/pages/Proto/service.ts 100.00% <0.00%> (ø)
web/src/hooks/usePagination.ts 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abefe97...da35f96. Read the comment docs.

@guoqqqi
Copy link
Member

guoqqqi commented Mar 12, 2022

Hi, @Si-ege can you add some images for this PR?

@Si-ege
Copy link
Contributor Author

Si-ege commented Mar 12, 2022

image

@guoqqqi
Copy link
Member

guoqqqi commented Mar 13, 2022

also cc @Baoyuantop PTAL

Copy link
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~

Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM, also cc @hanzhenfang take a look

web/src/components/Plugin/PluginPage.tsx Outdated Show resolved Hide resolved
Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guoqqqi
Copy link
Member

guoqqqi commented Apr 15, 2022

The preview
image
The Global Plugin
image
Cool 👍

@juzhiyuan juzhiyuan merged commit 0e6411f into apache:master Apr 17, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request May 24, 2022
* upstream: (28 commits)
  docs: update some tips in develop.md (apache#2451)
  fix: create upstream error when pass host is node and nodes without port (apache#2421)
  fix: correct data  type of filed Active.checks.active.https_verify_certificate (apache#2422)
  feat: basic support Apache APISIX 2.13.0 (apache#2428)
  feat: add page reload judgment (apache#2370)
  docs: Update RPM install package link (apache#2439)
  docs: Remove hyperlinks from documents (apache#2431)
  chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423)
  fix: consumer without plugins causes page crashes (apache#2437)
  chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420)
  feat: Modify plugin preview page (apache#2359)
  chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418)
  chore: use json schema instead hard code (apache#2399)
  refactor: migrate route tests to e2enew (apache#2411)
  chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414)
  chore: update the year of copyright and fix typo (apache#2417)
  docs: update online playground url (apache#2416)
  chore: update README for online demo (apache#2404)
  refactor: migrate id compatible tests to e2enew (apache#2400)
  docs: fix invalid link (apache#2366)
  ...

# Conflicts:
#	api/internal/route.go
#	web/src/components/Footer/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在预览插件的时候,建议只显示启动的插件而不是显示所有的插件
6 participants