fix: correct data type of filed Active.checks.active.https_verify_certificate #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2422 +/- ##
==========================================
+ Coverage 68.10% 71.58% +3.47%
==========================================
Files 127 58 -69
Lines 3374 4036 +662
Branches 830 0 -830
==========================================
+ Hits 2298 2889 +591
+ Misses 1076 843 -233
- Partials 0 304 +304
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tylitianrui
changed the title
tylitianrui
changed the title
tylitianrui
changed the title
Baoyuantop
reviewed
May 6, 2022
Baoyuantop
approved these changes
May 7, 2022
oil-oil
approved these changes
May 7, 2022
bzp2010
approved these changes
May 7, 2022
juzhiyuan
approved these changes
May 7, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
May 24, 2022
* upstream: (28 commits) docs: update some tips in develop.md (apache#2451) fix: create upstream error when pass host is node and nodes without port (apache#2421) fix: correct data type of filed Active.checks.active.https_verify_certificate (apache#2422) feat: basic support Apache APISIX 2.13.0 (apache#2428) feat: add page reload judgment (apache#2370) docs: Update RPM install package link (apache#2439) docs: Remove hyperlinks from documents (apache#2431) chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423) fix: consumer without plugins causes page crashes (apache#2437) chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420) feat: Modify plugin preview page (apache#2359) chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418) chore: use json schema instead hard code (apache#2399) refactor: migrate route tests to e2enew (apache#2411) chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414) chore: update the year of copyright and fix typo (apache#2417) docs: update online playground url (apache#2416) chore: update README for online demo (apache#2404) refactor: migrate id compatible tests to e2enew (apache#2400) docs: fix invalid link (apache#2366) ... # Conflicts: # api/internal/route.go # web/src/components/Footer/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
i set active health check with https , and filed
Active.checks.active.https_verify_certificatein request body was true ( bool ). it return error (json: cannot unmarshal bool into Go struct field Active.checks.active.https_verify_certificate of type string). it is filedActive.checks.active.https_verify_certificatein golang that is a string ，different to filedActive.checks.active.https_verify_certificatein request. it is , alse , different with the one schema defined in apisix.Please update this section with detailed description.
Related issues
Checklist: