Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports of vendored cgroupspy #22207

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 12, 2022

This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.

This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.

This is part of the effort needed to implement Python 3.10
compatibility: #22050


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk force-pushed the fix-imports-of-vendored-cgroupspy branch from e240bdb to 8b5898a Compare March 12, 2022 16:21
@potiuk potiuk mentioned this pull request Mar 12, 2022
@potiuk potiuk force-pushed the fix-imports-of-vendored-cgroupspy branch from 8b5898a to 3d86b7e Compare March 13, 2022 15:04
@potiuk potiuk requested a review from eladkal March 13, 2022 21:15
@potiuk potiuk force-pushed the fix-imports-of-vendored-cgroupspy branch from 6a7aa6d to 6080889 Compare March 14, 2022 18:26
@potiuk potiuk force-pushed the fix-imports-of-vendored-cgroupspy branch from 6080889 to 4479b01 Compare March 19, 2022 21:07
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.

This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.

This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk potiuk force-pushed the fix-imports-of-vendored-cgroupspy branch from 4479b01 to 26c7e19 Compare March 20, 2022 09:57
@potiuk
Copy link
Member Author

potiuk commented Mar 20, 2022

This is the next in line to get the Python 3.10 compatibility. Three more commits to go :)

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 20, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 172df9e into apache:main Mar 20, 2022
@potiuk potiuk deleted the fix-imports-of-vendored-cgroupspy branch March 20, 2022 11:19
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 7, 2022
@potiuk potiuk restored the fix-imports-of-vendored-cgroupspy branch April 26, 2022 20:53
@potiuk potiuk deleted the fix-imports-of-vendored-cgroupspy branch July 29, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants