Fix python 3.10 support in vendored in cgroupspy #22208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
eladkal,
kaxil,
mik-laj,
turbaszek,
uranusjr and
jedcunningham
potiuk
force-pushed
the
fix-cgroupspy-python-3.10-compatibility
branch
from
64b8390 to
9a8af80
Compare
potiuk
force-pushed
the
fix-cgroupspy-python-3.10-compatibility
branch
2 times, most recently
from
06ea3ff to
47e1ecb
Compare
potiuk
force-pushed
the
fix-cgroupspy-python-3.10-compatibility
branch
2 times, most recently
from
f0dfeb5 to
391e813
Compare
The cgrouppspy is not Python 3.10 compliant due to Iterable being imported directly from collections. This is captured in cloudsigma/cgroupspy#13 We fix it in our vendored-in version of cgroupspy until hopefully new version of it is released. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050
potiuk
force-pushed
the
fix-cgroupspy-python-3.10-compatibility
branch
from
391e813 to
0c7507b
Compare
|
This is the next one for Python 3.10 :) |
eladkal
approved these changes
Mar 20, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 4, 2022
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14
Merged
potiuk
added a commit
that referenced
this pull request
Apr 4, 2022
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.