Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10 support #22050

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Add Python 3.10 support #22050

merged 1 commit into from
Mar 21, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 7, 2022 •
edited
Loading

Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.

Closes: #19059

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

I think we should be close to get Python 3.10 support. Let's see

@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Mar 7, 2022
@potiuk potiuk closed this Mar 7, 2022
@potiuk potiuk reopened this Mar 7, 2022
@potiuk potiuk force-pushed the add-python-3-10-support branch from 4a2a616 to b92fda0 Compare March 7, 2022 13:52
@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.

@potiuk potiuk force-pushed the add-python-3-10-support branch from b92fda0 to 102848f Compare March 7, 2022 14:56
@mik-laj
Copy link
Member

mik-laj commented Mar 7, 2022

Should we remove user warning?

airflow/airflow/__main__.py

Lines 38 to 43 in 6db9b00

if PY310:
docs_url = get_docs_url('installation/prerequisites.html')
warnings.warn(
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
)

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

Should we remove user warning?

airflow/airflow/__main__.py

Lines 38 to 43 in 6db9b00

if PY310:
docs_url = get_docs_url('installation/prerequisites.html')
warnings.warn(
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
)

Yep. That too :)

@potiuk potiuk force-pushed the add-python-3-10-support branch from 102848f to d3aa026 Compare March 7, 2022 15:05
@Bowrna
Copy link
Contributor

Bowrna commented Mar 8, 2022

@potiuk Do I have to make changes in Breeze2 to support Python 3.10?

@potiuk
Copy link
Member Author

potiuk commented Mar 8, 2022

@potiuk Do I have to make changes in Breeze2 to support Python 3.10?

No need. I made a "bulk" update here and I also updated Breeze2 :D

@potiuk potiuk force-pushed the add-python-3-10-support branch 3 times, most recently from 1240212 to d0f1871 Compare March 11, 2022 19:58
@potiuk potiuk marked this pull request as ready for review March 11, 2022 20:00
@potiuk potiuk requested review from ashb and mik-laj as code owners March 11, 2022 20:00
@potiuk potiuk force-pushed the add-python-3-10-support branch from d0f1871 to 77ebb39 Compare March 11, 2022 21:45
@potiuk
Copy link
Member Author

potiuk commented Mar 11, 2022 •
edited
Loading

We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13

@potiuk potiuk mentioned this pull request Mar 12, 2022
Merged
@potiuk potiuk mentioned this pull request Mar 12, 2022
Merged
@potiuk potiuk force-pushed the add-python-3-10-support branch from 7a20762 to 740f3c9 Compare March 20, 2022 10:00
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e 
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.

This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.

This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b 
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.

This is captured in cloudsigma/cgroupspy#13

We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.

This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f 
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk potiuk force-pushed the add-python-3-10-support branch from 740f3c9 to 03bcfea Compare March 20, 2022 11:27
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089 
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.

This is captured in cloudsigma/cgroupspy#13

We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.

This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9 
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit that referenced this pull request Mar 21, 2022
@potiuk
Switched cgroupspy to vendored version (#22209)
62740c2 
This is part of the effort needed to implement Python 3.10
compatibility: #22050
@potiuk potiuk force-pushed the add-python-3-10-support branch from 03bcfea to 6bc53a4 Compare March 21, 2022 20:52
@potiuk
Copy link
Member Author

potiuk commented Mar 21, 2022

Final PR to get Python 3.10 support !

@potiuk potiuk closed this Mar 21, 2022
@potiuk potiuk reopened this Mar 21, 2022
@potiuk
Add Python 3.10 support
9c140ce 
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.

Closes: apache#19059
@potiuk potiuk force-pushed the add-python-3-10-support branch from 6bc53a4 to 9c140ce Compare March 21, 2022 22:34
@potiuk potiuk merged commit 4c28c2a into apache:main Mar 21, 2022
@potiuk potiuk deleted the add-python-3-10-support branch March 21, 2022 23:36
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@eladkal eladkal Awaiting requested review from eladkal

@dstandish dstandish Awaiting requested review from dstandish

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support
5 participants
@potiuk @mik-laj @Bowrna @alexott @ephraimbuddy