Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave wallet update #480

Closed
wants to merge 2 commits into from
Closed

Brave wallet update #480

wants to merge 2 commits into from

Conversation

darkdh
Copy link
Contributor

@darkdh darkdh commented Jul 21, 2022

  1. Address comment
  2. Update example to include BraveWalletAdapter

@darkdh darkdh mentioned this pull request Jul 21, 2022
Merged
@darkdh darkdh changed the title Brae wallet update Brave wallet update Aug 2, 2022
@jordaaash
Copy link
Collaborator

Wallet Adapter was intended to be neutral and not provide recommendations of any wallet, or even implicit guarantees that they work properly. It hasn't always done that.

#498 has removed all adapters from the examples and starter projects, and we will solve this problem with better docs and support rather than appearing to promote or prioritize any wallet.

@jordaaash jordaaash closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @jordaaash