Add Brave Wallet #445
Add Brave Wallet #445
Conversation
There was a problem hiding this comment.
Thanks for this! Please don't copy the Phantom adapter's behavior though.
I also want to mention that we're working on an actual wallet standard, which will be introduced soon. More context on that here and here.
When that's ready for review, I'd love to get your feedback and work on a migration plan.
darkdh
force-pushed
the
brave-wallet
branch
2 times, most recently
from
86ddf28 to
94a6cae
Compare
|
I'd love to review this again but the new force pushes caused the context of the review comments to all be lost. Please don't do that! |
|
Thanks so much! I'll plan to release this tomorrow. |
| if (!wallet) throw new WalletNotConnectedError(); | ||
|
|
||
| try { | ||
| return (await wallet.signTransaction(transaction)) || transaction; |
There was a problem hiding this comment.
When would you want to return the original transaction? Is this in cases where it's already signed?
There was a problem hiding this comment.
That shouldn't never happen even when input transaction is signed.
Note that most of the code is inherited from Phantom adapter including this part.
There was a problem hiding this comment.
Cool! If Brave's wallet.signTransaction can never return null, you should uninherit this part :)
Resolve brave/brave-browser#19468
Brave has both
solana.isPhantomandsolana.isBraveWalletset to true for maximum compatibilityBrave Wallet for Solana dApp support is only available in Nightly