Add support for SKY Wallet

[skywalletadmin]

This PR adds support for SKY Wallet
Currently SKY Wallet works as a DApp Browser Implementation inside the SKY Wallet mobile app. Support for Chrome and Safari coming soon.

[jordaaash]

Hey, I want to address the lack of activity on your PR. Thank you for your patience!

Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment)

Let's discuss in that thread to keep it in one place.

[jordaaash]

While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.

Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.

[skywalletadmin]

Thanks Jordan for the review on this PR. We have resolved all your comments and pushed the new changes. Looking forward to seeing SKY Wallet integrated with this PR. Please let me know if any other changes are required. Thanks!

[skywalletadmin]

Hi Jordan,
Thanks for reviewing the PR again.
We've fixed the following issues -

1. ContextProvider class has been reverted out of the PR.
2. sendTransaction implementation has been corrected
3. dependencies have been corrected in package.json

Please let us know if there's any other changes we should make. Appreciate your support!

[skywalletadmin]

Hi Jordan,
Thanks for your review on this PR. We have addressed and fixed all the review comments.
Please let us know if there are any other changes to this. Much appreciated!

[skywalletadmin]

Hi Jordan,
Thanks for your review! We've fixed the issues and made the changes. Please let us know if there's any thing else. Thanks!

[jordaaash]

Published:

• @solana/[email protected]
• @solana/[email protected]