Encourage developers to hand-pick the selection of wallets most appropriate for their audience #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As third-party wallet offerings evolve, our starter apps continue to put forth a starter list of wallets that does not. Besides going stale over time, the decision of which wallets a dApp should support is not a responsibility of
wallet-adapter
itself; ultimately, the decision of which wallets to support rests with the dApp publisher themselves.Summary of changes
FakeWalletAdapter
that conforms to the wallet adapter interface, but otherwise offers no useful signing/sending services.FakeWalletAdapter
in all of the starter packs, along with instructions on where to find real wallet adapters.Test plan
yarn && yarn build
cd packages/starter/example && yarn dev
Screen.Recording.2022-08-02.at.3.33.53.PM.mov
yarn && yarn build
cd packages/starter/react-ui-starter && yarn start
Screen.Recording.2022-08-02.at.3.43.29.PM.mov
Observe warning on the developer console that links to this document.