Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage developers to hand-pick the selection of wallets most appropriate for their audience #498

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

steveluscher
Copy link
Collaborator

@steveluscher steveluscher commented Aug 2, 2022

Problem

As third-party wallet offerings evolve, our starter apps continue to put forth a starter list of wallets that does not. Besides going stale over time, the decision of which wallets a dApp should support is not a responsibility of wallet-adapter itself; ultimately, the decision of which wallets to support rests with the dApp publisher themselves.

Summary of changes

  • Create a FakeWalletAdapter that conforms to the wallet adapter interface, but otherwise offers no useful signing/sending services.
  • Include FakeWalletAdapter in all of the starter packs, along with instructions on where to find real wallet adapters.

Test plan

  1. yarn && yarn build
  2. cd packages/starter/example && yarn dev
  3. Open https://localhost:3000
Screen.Recording.2022-08-02.at.3.33.53.PM.mov
  1. yarn && yarn build
  2. cd packages/starter/react-ui-starter && yarn start
  3. Open https://localhost:1234
Screen.Recording.2022-08-02.at.3.43.29.PM.mov

Observe warning on the developer console that links to this document.

image

@steveluscher steveluscher requested a review from jordaaash August 2, 2022 22:45
@jordaaash
Copy link
Collaborator

LGTM!

@steveluscher steveluscher merged commit 24e68a2 into anza-xyz:master Aug 2, 2022
@steveluscher steveluscher deleted the byow branch August 2, 2022 23:34
This was referenced Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants