Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract genesis-config crate #3860

Closed
wants to merge 3 commits into from
Closed

Extract genesis-config crate #3860

wants to merge 3 commits into from

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Dec 2, 2024 •
edited
Loading

Problem

solana_sdk::genesis_config imposes a solana_sdk dep on svm crates

Summary of Changes

  • Move to its own crate and re-export with deprecation
  • Also move solana_sdk::{hard_forks, shred_version} to this crate
  • Make serde and bincode optional in the new crate

This branches off #3855 so that needs to be merged first (update: done)

@kevinheavey kevinheavey force-pushed the extract-genesis-config branch 4 times, most recently from 4c96cee to 2cbab50 Compare December 4, 2024 20:59
@kevinheavey kevinheavey force-pushed the extract-genesis-config branch from 2cbab50 to 07fe169 Compare December 5, 2024 13:43
@kevinheavey kevinheavey marked this pull request as ready for review December 5, 2024 14:05
@kevinheavey kevinheavey mentioned this pull request Dec 6, 2024
Merged
@kevinheavey kevinheavey marked this pull request as draft December 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need:merge-assist
Projects
SDK Breakup + Breakout
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinheavey