extract poh-config crate #3855
Merged
extract poh-config crate #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-poh-config
branch
2 times, most recently
from
d194eb8 to
4f87316
Compare
kevinheavey
force-pushed
the
extract-poh-config
branch
from
778774a to
c35c84b
Compare
joncinque
reviewed
Dec 5, 2024
| pub extern crate bs58; | ||
| extern crate log as logger; | ||
| #[cfg_attr(not(target_os = "solana"), macro_use)] |
There was a problem hiding this comment.
After moving out poh_config, we were getting an unused macro warning that this fixes
joncinque
approved these changes
Dec 5, 2024
yihau
added
the
automerge
buffalojoec
reviewed
Dec 5, 2024
|
That would have been a breaking change |
|
Isn't |
|
It would be a breaking change for anyone building with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::poh_configblocks moving outsolana_sdk::genesis_configand imposes asolana_sdkdep on svm cratesSummary of Changes
unchecked_div_by_constwith regular const division and a check for non-zero denominator, to avoid a solana-program dep