sdk: evict hard_forks

[buffalojoec]

Problem

Moving toward evicting rent_collector from the SDK, hard_forks stands in the way.
#3932

Summary of Changes

Extract it into solana-hard-forks standalone crate.

[buffalojoec]

Note CI is broken on master.

[joncinque]

Looks good overall! Just tiny things. I hesitated about whether we should use the Slot type from solana_clock for better clarity.

It's such a tiny type that it seems silly to add the dependency for a type alias, and the API is clear enough that they're slots, so I lean towards your approach.

[buffalojoec]

I hesitated about whether we should use the Slot type from solana_clock for better clarity.

It's such a tiny type that it seems silly to add the dependency for a type alias, and the API is clear enough that they're slots, so I lean towards your approach.

Yeah I feel like the dependency for just a type alias is silly, too. I noticed we've moved to u64 in other crates that got split out, so I think that's fine to do here as well.

[kevinheavey]

Will this end up being used anywhere that the solana-genesis-config crate is not used? If not we could just put them in the same crate #3860

No strong feelings though, I consider crates cheap

[buffalojoec]

Will this end up being used anywhere that the solana-genesis-config crate is not used? If not we could just put them in the same crate #3860

No strong feelings though, I consider crates cheap

There are a few places it's used without genesis_config, but putting them in the same crate wouldn't break those callsites (esp. if we do the proper re-exporting in SDK). I just felt like they made sense separate from each other, given they aren't too tightly coupled concepts.

[joncinque]

Just the last bit to fix, then we can get this in. @yihau can you accept solana-hard-forks?

[joncinque]

According to the failing test, looks like a frozen-abi digest needs to be updated:

thread 'bank::serde_snapshot::tests::test_bank_serialize::BankAbiTestWrapper_frozen_abi::test_abi_digest' panicked at runtime/src/bank/serde_snapshot.rs:573:13:
assertion `left == right` failed: Possibly ABI changed? Confirm the diff by rerunning before and after this test failed with SOLANA_ABI_DUMP_DIR!
  left: "2bWtYJSWVVvCEnBw6W2PsYZaR7RVs2V7CthFcHArdbUR"
 right: "9NABbrKjv1mmcPAmvtav1tVq4cJ7tTwKpHbYj6RDp3hi"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test bank::serde_snapshot::tests::test_bank_serialize::BankAbiTestWrapper_frozen_abi::test_abi_digest ... FAILED

[buffalojoec]

According to the failing test, looks like a frozen-abi digest needs to be updated:

Sorry, I didn't see this was failing after I committed your suggestion. Will fix.

[joncinque]

Sorry, one last thing to gate this properly on the full feature as it was before

[joncinque]

Looks great!