[zk-sdk] Add sigma_proofs and transcript modules
#1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
zk-sdk-sigma
branch
from
1bfe8ef to
4e594dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
=========================================
+ Coverage 82.0% 82.1% +0.1%
=========================================
Files 860 880 +20
Lines 232898 235280 +2382
=========================================
+ Hits 191071 193351 +2280
- Misses 41827 41929 +102 |
joncinque
approved these changes
Apr 26, 2024
Comment on lines
+65
to
+73
| fn rangeproof_from_key_domain_separator(&mut self, n: u64) { | ||
| self.append_message(b"dom-sep", b"rangeproof from opening v1"); | ||
| self.append_u64(b"n", n); | ||
| } | ||
|
|
||
| fn rangeproof_from_opening_domain_separator(&mut self, n: u64) { | ||
| self.append_message(b"dom-sep", b"rangeproof from opening v1"); | ||
| self.append_u64(b"n", n); | ||
| } |
There was a problem hiding this comment.
Are these meant to be the same? It seems like the first one should be a different name
There was a problem hiding this comment.
Yeah so the rangeproof_from_key_... should append the message rangeproof from key v1. We also seem to have function close_account_proof_domain_separator, which is not deprecated and not used any more... I will clean up transcript on a follow-up. Sorry I should have caught this when I am migrating things over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a follow-up to #1019, which migrates the
transcriptandsigma_proofsmodules fromzk-token-sdkintozk-sdk. The only additional change to these modules is that the suffix_proofis removed from the sigma proof module names.As in
zk-token-sdk, thesigma_proofsandtranscriptmodules were not included in the sbf target since they rely on the curve25519 dalek crate, which does not build well in sbf.The
dead_codeandunused_importswere added since the rest of thezk-token-sdk, which uses these modules, have not been migrated yet.There are some naming changes that are required in the
sigma_proofsmodule as specified in #671. These will be done in subsequent PRs.