[zk-sdk] Add errors, macros, and encryption modules
#1019
Conversation
samkim-crypto
force-pushed
the
zk-sdk-encryption
branch
from
9b06acd to
574e673
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
=========================================
+ Coverage 81.9% 82.1% +0.1%
=========================================
Files 857 864 +7
Lines 232441 233160 +719
=========================================
+ Hits 190583 191432 +849
+ Misses 41858 41728 -130 |
|
I also realized that everything in the |
| @@ -10,6 +10,9 @@ | |||
| //! - Basic type-wrapper around the AES-GCM-SIV symmetric authenticated encryption scheme | |||
| //! implemented by [aes-gcm-siv](https://docs.rs/aes-gcm-siv/latest/aes_gcm_siv/) crate. | |||
|
|
|||
| #[cfg(not(target_os = "solana"))] | |||
| #[macro_use] | |||
There was a problem hiding this comment.
Sorry, looking through this again, I don't think you need #[macro_use] either
There was a problem hiding this comment.
Oh oops, yeah I guess this is only required by old rust. Thanks! I will removed on a follow-up.
There was a problem hiding this comment.
Hm, actually it seems like if I removed this macro_use then the macros seem to be not accessible to other crates. Reading a bit on the macro_use attribute, it seems like this is required here?
There was a problem hiding this comment.
Ah ok, I thought the macros were only used internally. no worries then!
Summary of Changes
This is a follow-up to #988, which migrates the
errors,macros, andencryptionmodules fromzk-token-sdkintozk-sdk. The only additional change to these modules is that the deprecated functions are now removed.Since the encryption module is largely the same in
zk-token-sdkandzk-sdk, we can consider removing and re-exporting the functions/types inzk-token-sdkto the ones inzk-sdk. Sincezk-token-sdkwill not get any updates and then eventually be removed, I thought I would just leave it as is. We can consider re-exporting in a follow-up.Fixes #