Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a number of breaking changes that must be made to the solana-zk-token-sdk (#671) that break downstream (essentially just spl). To lift the CI spl downstream check, we need to wait until we have a v2.0 release. However, confidential transfers in the token extensions is high priority and it would be really great if we can include these changes as part of the v2.0 release. Furthermore, the necessary changes we would need includes renaming
solana-zk-token-sdk
tosolana-zk-sdk
. It would actually make things a lot simpler if we publish a newsolana-zk-sdk
, migrate the logic fromsolana-zk-token-sdk
to it, and then deprecatesolana-zk-token-sdk
in the future.Summary of Changes
Create the
zk-sdk
crate. I don't have anything in the crate yet. Each submodules from thezk-token-sdk
will be moved into the new crate incrementally.Fixes #