[zk-sdk] Add range_proof module
#1091
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
========================================
Coverage 82.1% 82.1%
========================================
Files 881 886 +5
Lines 235742 236383 +641
========================================
+ Hits 193677 194244 +567
- Misses 42065 42139 +74 |
samkim-crypto
force-pushed
the
zk-sdk-rangeproof
branch
from
a74de22 to
dec8702
Compare
zk-sdk/src/range_proof/generators.rs
Outdated
| #[cfg(not(target_os = "solana"))] | ||
| const MAX_GENERATOR_LENGTH: usize = u32::MAX as usize; |
There was a problem hiding this comment.
Is this meant to have the #[cfg(...)] here? It's used later in code that's not gated with the same cfg
There was a problem hiding this comment.
Oh yes, the entire generators module is included in #[cfg(...)]`, so this is actually not needed. It seems like this is a relic of the past before some of the refactoring was done... I removed it. Thanks!
zk-sdk/src/range_proof/generators.rs
Outdated
|
|
||
| #[allow(non_snake_case)] | ||
| #[derive(Clone)] | ||
| pub struct BulletproofGens { |
There was a problem hiding this comment.
I thought Bulletproof would get changed to RangeProof, is that not the case?
There was a problem hiding this comment.
Oh wait, this is the bulletproofs generators. Yes, those should be changed 🙏
samkim-crypto
force-pushed
the
zk-sdk-rangeproof
branch
from
43abd8d to
b032a38
Compare
Summary of Changes
This is a follow-up to #1065, which migrates the
range_proofmodule from thezk-token-sdkintozk-sdk.Everything from the range proof module seemed to be fine and so it is copied verbatim, with the exception of
allow(dead_code)to prevent ci from complaining, and a minor update to comments.