Add some nuance to the on-off logic for RESOURCE_SERVER #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
Sep 4, 2024
relrod
approved these changes
Sep 4, 2024
AlanCoding
force-pushed
the
sync_settings
branch
from
b020a0c to
469e59c
Compare
|
AlanCoding
added a commit
that referenced
this pull request
Oct 8, 2024
While revisiting ansible/eda-server#1061, I realized that `RESOURCE_SERVER_SYNC_ENABLED` is not set to True. This will not work to do what we want. As of #603, for any practical system (excluding test_app specifically here), we will be safe to have a True value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to dynaconf implementation details, I discovered that eda-server may set
{"URL": None}for theRESOURCE_SERVERsetting. This is totally fine with me, and should be the same as not defining that setting. But it requires this code change.Fixes #602