[Alt 1] Flip default of reverse sync to True #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First thing I wanted to establish is that
Are both passing. We will still need ansible/eda-server#1061 to actually use the feature, but the checks themselves don't have any coverage for it, so that's why they can pass now. |
fosterseth
approved these changes
Sep 25, 2024
AlanCoding
changed the title
|
Votes were in favor of the other alternative |
AlanCoding
force-pushed
the
sync_default
branch
from
933f498 to
773e6cc
Compare
|
Another update - the other alternative is blocked because it requires more installer changes. So this is our only sensible option for now. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While revisiting ansible/eda-server#1061, I realized that
RESOURCE_SERVER_SYNC_ENABLEDis not set to True.This will not work to do what we want.
As of #603, for any practical system (excluding test_app specifically here), we will be safe to have a True value.
For some reason, we had planned to make this change in apps like AWX / eda-server, but this doesn't make sense to me. Making this change seems like the most reasonable.