Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Means to silence log "Reverse sync will not be enabled" #602

Closed
AlanCoding opened this issue Sep 3, 2024 · 0 comments · Fixed by #603
Closed

Means to silence log "Reverse sync will not be enabled" #602

AlanCoding opened this issue Sep 3, 2024 · 0 comments · Fixed by #603
Labels

Comments

@AlanCoding
Copy link
Member

We saw these logs from the resource provider server:

2024-09-03 13:40:03,562 ERROR     ansible_base.resource_registry.apps RESOURCE_SERVER is not configured. Reverse sync will not be enabled.

This is unnecessarily alarmist. The resource provider should never consider doing reverse sync, because it does sync, but that's a forward sync!

This proposes that if RESOURCE_SERVER_SYNC_ENABLED is set to False, then we simply do not emit that log. That is all. This is a non-functional change. Only logs will be affected.

AlanCoding added a commit that referenced this issue Sep 4, 2024
Due to dynaconf implementation details, I discovered that eda-server may
set `{"URL": None}` for the `RESOURCE_SERVER` setting. This is totally
fine with me, and should be the same as not defining that setting. But
it requires this code change.

Fixes #602

This also makes the new auth class a no-op when the resource server
is not defined, reusing that same logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant