-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy web and task component in independent deployment #1218
Conversation
cf1a98c
to
8cb2914
Compare
997f44f
to
6a2259c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not find any references to tower_pod
in revised code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now I think this looks good, I am not seeing anything immediately on my first pass that would be a cause for concern. I will continue going through current code base to make sure we are renaming everything to the new names etc.
the CI/molecule failure is caused by this
which we were able to reproduce locally. This is caused by us not being able to override the default image and image_version for the molecule deployment. By default, those are set to devel which will fail molecule testing because the new launch script for the rsyslog sidecar is not found in the devel image, but rather the feature image for this new split feature. #1308 has been opened to fix this. we were able to fix this locally by just swapping the hardcoded image and image_version. |
1192c5b
to
4e33731
Compare
@@ -340,6 +238,8 @@ spec: | |||
- /var/lib/pre-stop/scripts/termination-master | |||
{% endif %} | |||
env: | |||
- name: AWX_COMPONENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is added so that awx get_task_qeuename() function can identify when in web container and will try to select a task instance's queue
4364126
to
fded1d1
Compare
Signed-off-by: Rick Elrod <[email protected]>
Signed-off-by: Rick Elrod <[email protected]>
This is a breaking change since 'replicas' is no longer used. Signed-off-by: Rick Elrod <[email protected]>
#1189) * first pass, still WIP, need tolerations etc * add tolerations that don't work bc idk * bug hunting * local push, still a WIP * affinity still needs testfor to_nice_yaml, tolerations logic is working * fixed task deployment and affinity for both
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
Signed-off-by: jessicamack <[email protected]>
update logic for determining if install.yml task should be run to respect the auto_upgrade field in awx resource conditions and expected behavior ``` auto_upgrade awx awx-web awx-task run install.yml -------------- ----- --------- ---------- ----------------- T - - - T F T - - F F - T T F F - T F T F - F T T F - F F T ```
for awx to be able to identify which component it is running in code
Added the following volume mounts to the web container: - receptor-work-signing - receptor-ca - work-public-key.pem Also added these corresponding volumes to the web deployments: - receptor-ca - receptor-work-signing
- rename scale_down vars to the new deployments since the old one no longer exists - rename postgres.yml scale down vars as it references the old ones as well
related to ansible/awx#13777 make sure that the launch script name reflect the component that its launching
SUPERVISOR_WEB_CONFIG_PATH is used in the old deployment for task container to reach into the web container and restart services this is no longer possible/needed after splitting the deployment renaming SUPERVISOR_WEB_CONFIG_PATH to SUPERVISOR_CONFIG_PATH and setting it to the supervisor file for the container this can still be useful to help run `supervisorctl -c $SUPERVISOR_CONFIG_PATH`
fded1d1
to
4a6d185
Compare
SUMMARY
Requires ansible/awx#13423 to function
ISSUE TYPE
ADDITIONAL INFORMATION