-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web/task split] Add web and task replicas to the CRD #1227
[web/task split] Add web and task replicas to the CRD #1227
Conversation
@thedoubl3j have you tested this? awx-operator/config/crd/bases/awx.ansible.com_awxs.yaml Lines 1436 to 1450 in 4b2b3af
i dont think this would work since there's also default in the crd which means that replicas will never have any effect |
@TheRealHaoLiu yes but I did it buy over riding the default and removing them. those have been removed by default |
just for grins, did you also try passing the spec without any replicas? |
@gamuniz yes, default persisted and replicas remained at 1. the CRD does still reflect 0 but still have
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
add web_replicas and task_replicas Co-Authored-By: Jake Jackson <[email protected]>
SUMMARY
Add the ability to toggle replica count for web and task separately with
web_replica
task_replica
or set the count as the same withreplicas
Portion of #1182
ISSUE TYPE
TESTING
The expectation of how the changes should work is that if desired, the user should be able to scale the numbers web and task replicas independently from each other or scale all replicas across all pods at the same rate.
test case 1: 1 task replica and 2 web replicas
CRD change:
result
test case 2: 2 task replicas and 1 web replica
CRD change:
result
test case 3: all replicas scaled to 3
CRD change:
result
test case 4: set replicas to 0 to test default behavior
CRD change:
result