-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web/task split] fix scale down bug #1295
Merged
thedoubl3j
merged 2 commits into
ansible:feature_web-task-split
from
thedoubl3j:scale_down
Mar 23, 2023
Merged
[web/task split] fix scale down bug #1295
thedoubl3j
merged 2 commits into
ansible:feature_web-task-split
from
thedoubl3j:scale_down
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedoubl3j
requested review from
relrod,
jessicamack,
TheRealHaoLiu and
djyasin
March 20, 2023 17:42
djyasin
approved these changes
Mar 20, 2023
TheRealHaoLiu
approved these changes
Mar 20, 2023
@thedoubl3j It looks like there is an entry in
|
@rooftopcellist take a look when you get a sec, I elected to check for a task deployment rather than just awx (doesn't exist anymore) or both since if one is there, the other will be as well. |
gamuniz
approved these changes
Mar 23, 2023
TheRealHaoLiu
pushed a commit
that referenced
this pull request
Mar 28, 2023
- rename scale_down vars to the new deployments since the old one no longer exists - rename postgres.yml scale down vars as it references the old ones as well
TheRealHaoLiu
pushed a commit
that referenced
this pull request
Mar 30, 2023
- rename scale_down vars to the new deployments since the old one no longer exists - rename postgres.yml scale down vars as it references the old ones as well
TheRealHaoLiu
pushed a commit
that referenced
this pull request
Mar 30, 2023
- rename scale_down vars to the new deployments since the old one no longer exists - rename postgres.yml scale down vars as it references the old ones as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes #1255
While working on cleanup, the scale down playbook didn't have the new naming conventions for the pods and would currently scale down nothing during any type of db upgrade etc.
This adds a simple list loop to scale down both pods during any db upgrade/migration/configuration in the operator.
ISSUE TYPE
ADDITIONAL INFORMATION
test case
To test this properly, we will need to either provoke the rescue block or do a db migration or upgrade. I think there is also a way to provoke it if there is no DB specified but I need to investigate this.
If anyone has any pointers or thoughts on how we can approach this, please share as I am running low on ideas.