Restore voting rights to ansible-galaxy-importer on community.aws #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 5m 11s |
jillr
approved these changes
Jul 6, 2022
|
@abikouo could you please review this PR and merge if you agree? |
alinabuzachis
approved these changes
Jul 7, 2022
|
LGTM |
abikouo
approved these changes
Jul 7, 2022
|
Just in case someone else wants to follow what happened:
|
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 49s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importer job originally broke because community.aws depends on the docs fragments from amazon.aws
The docs tests have been split off into GitHub actions (which cope with the cross-repo dependency), and the docs test disabled in ansible-galaxy-importer. Since the test performs other checks, give it back the right to vote.