Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable galaxy-importer docs tests #1270

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Disable galaxy-importer docs tests #1270

merged 1 commit into from
Jun 28, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 28, 2022 •
edited
Loading

SUMMARY

Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.

We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/galaxy-importer.cfg

ADDITIONAL INFORMATION

@tremble tremble changed the title Disable galaxy-importer docs tests [WIP] Disable galaxy-importer docs tests Jun 28, 2022
@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request needs_triage tests tests labels Jun 28, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
2 similar comments
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@tremble
Copy link
Contributor Author

tremble commented Jun 28, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 6m 00s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 34s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 30s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 03s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 47s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 40s

@tremble tremble changed the title [WIP] Disable galaxy-importer docs tests Disable galaxy-importer docs tests Jun 28, 2022
@tremble
Copy link
Contributor Author

tremble commented Jun 28, 2022

Concept works, needs a change in the zuul job too

@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Jun 28, 2022
@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Jun 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

Warning:
Change 1583 in project ansible/ansible-zuul-jobs does not share a change queue with 1270 in project ansible-collections/community.aws

@tremble
Copy link
Contributor Author

tremble commented Jun 28, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 42s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 30s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 04s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4435c8a into ansible-collections:main Jun 28, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble added backport-1.5 PR should be backported to the stable-1.5 branch backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Jun 29, 2022
@tremble tremble added the backport-4 PR should be backported to the stable-4 branch label Jun 29, 2022
@patchback
Copy link

patchback bot commented Jun 29, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/4435c8a64eada664d0d2cf742e8b2687058faf76/pr-1270

Backported as #1278

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jun 29, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/4435c8a64eada664d0d2cf742e8b2687058faf76/pr-1270

Backported as #1279

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jun 29, 2022 •
edited
Loading

Backport to stable-1.5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1.5/4435c8a64eada664d0d2cf742e8b2687058faf76/pr-1270

Backported as #1280

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jun 29, 2022 •
edited
Loading

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/4435c8a64eada664d0d2cf742e8b2687058faf76/pr-1270

Backported as #1281

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 29, 2022
@tremble @patchback
Disable galaxy-importer docs tests (#1270)
38378f9 
Disable galaxy-importer docs tests

SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

(cherry picked from commit 4435c8a)
patchback bot pushed a commit that referenced this pull request Jun 29, 2022
@tremble @patchback
Disable galaxy-importer docs tests (#1270)
4550561 
Disable galaxy-importer docs tests

SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

(cherry picked from commit 4435c8a)
@patchback patchback bot mentioned this pull request Jun 29, 2022
Merged
patchback bot pushed a commit that referenced this pull request Jun 29, 2022
@tremble @patchback
Disable galaxy-importer docs tests (#1270)
3625d88 
Disable galaxy-importer docs tests

SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

(cherry picked from commit 4435c8a)
patchback bot pushed a commit that referenced this pull request Jun 29, 2022
@tremble @patchback
Disable galaxy-importer docs tests (#1270)
98b0f0e 
Disable galaxy-importer docs tests

SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

(cherry picked from commit 4435c8a)
This was referenced Jun 29, 2022
Merged
Merged
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 29, 2022
@patchback
Disable galaxy-importer docs tests (#1270) (#1278)
233fc0e 
[PR #1270/4435c8a6 backport][stable-3] Disable galaxy-importer docs tests

This is a backport of PR #1270 as merged into main (4435c8a).
SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 29, 2022
@patchback
Disable galaxy-importer docs tests (#1270) (#1279)
aba30a0 
[PR #1270/4435c8a6 backport][stable-4] Disable galaxy-importer docs tests

This is a backport of PR #1270 as merged into main (4435c8a).
SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 29, 2022
@patchback
Disable galaxy-importer docs tests (#1270) (#1281)
ed31111 
[PR #1270/4435c8a6 backport][stable-2] Disable galaxy-importer docs tests

This is a backport of PR #1270 as merged into main (4435c8a).
SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 29, 2022
@patchback
[PR #1270/4435c8a6 backport][stable-1.5] Disable galaxy-importer docs…
9eb2d70 
… tests (#1280)

[PR #1270/4435c8a6 backport][stable-1.5] Disable galaxy-importer docs tests

This is a backport of PR #1270 as merged into main (4435c8a).
SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble mentioned this pull request Jul 7, 2022
Merged
@tremble tremble deleted the galaxy-importer/disable-docs branch July 7, 2022 19:26
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@markuman
elbv2: respect UseExistingClientSecret (ansible-collections#1270)
c6906a3 
elbv2: respect UseExistingClientSecret

SUMMARY
Since amazon.aws 5.0.0, elb_application_lb runs into an exception, when using Type: authenticate-oidc in a rule, even when UseExistingClientSecret: True parameter is given. That works as expected with amazon.aws 4.x.x.
The logic gets broken in  ansible-collections#940
Basically AWS won't return both, UseExistingClientSecret and  ClientSecret.
But when requesting against boto3,  both parameters are mutually exclusive!
When the user set UseExistingClientSecret: True, the ClientSecret must be removed for the request.
When the user does not set UseExistingClientSecret or set it to False,  the UseExistingClientSecret must be included in the request.
While diving deeper, I've noticed a basic change detection problem for default values, that are not requested, but AWS will return them. I've summerized it in ansible-collections#1284
However, this PR does not target ansible-collections#1284, it just fixes the exception and restores the functionality and hotfix the change-detection only for Type: authenticate-oidc.
origin PR description

The error was: botocore.errorfactory.InvalidLoadBalancerActionException: An error occurred (InvalidLoadBalancerAction) when calling the ModifyRule operation: You must either specify a client secret or set UseExistingClientSecret to true

UseExistingClientSecret is not respected anymore since a.a 5
Introduced in ansible-collections#940
Furthermore, AWS returns also Scope and  SessionTimeout parameters that are filled with default values if not requested.
'Scope': 'openid',
'SessionTimeout': 604800,

That make the module always returns a change, if they are not requested.
This fix does not break backwards compatibility, because the values are already set by aws, when not requested yet.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
plugins/module_utils/elbv2.yml
ADDITIONAL INFORMATION


          - Conditions:
              - Field: host-header
                Values:
                  - some.tld
              - Field: path-pattern
                Values:
                  - "/admin/*"
            Actions:
              - Type: authenticate-oidc
                Order: 1
                AuthenticateOidcConfig:
                  Issuer: https://login.microsoftonline.com/32rw-ewad53te-ef/v2.0
                  AuthorizationEndpoint: https://login.microsoftonline.com/324re-dafs6-6tw/oauth2/v2.0/authorize
                  TokenEndpoint: https://login.microsoftonline.com/432535ez-rfes-32543ter/oauth2/v2.0/token
                  UserInfoEndpoint: https://graph.microsoft.com/oidc/userinfo
                  ClientId: fasgd-235463-fsgd-243
                  ClientSecret: "{{ lookup('onepassword', 'some cool secret', vault='some important vault') }}"
                  SessionCookieName: AWSELBAuthSessionCookie
                  OnUnauthenticatedRequest: authenticate
                  UseExistingClientSecret: True
              - TargetGroupName: "{{ some_tg }}"
                Type: forward
                Order: 2

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-1.5 PR should be backported to the stable-1.5 branch backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @goneri @ansibullbot