Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring galaxy-importer #1583

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Support configuring galaxy-importer #1583

merged 1 commit into from
Jun 28, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 28, 2022

Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.

We're separately testing the docs more thoroughly using a github action, so we should be able to disable the broken docs fragment testing via galaxy-importer

tremble added a commit to tremble/community.aws that referenced this pull request Jun 28, 2022
@tremble
Disable galaxy-importer docs tests
dc11d27 
Depends-On: ansible/ansible-zuul-jobs#1583
@tremble tremble mentioned this pull request Jun 28, 2022
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 22s
✔️ ansible-tox-py38 SUCCESS in 6m 25s
✔️ ansible-tox-py39 SUCCESS in 5m 41s
✔️ ansible-tox-py310 SUCCESS in 5m 32s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-tox-linters FAILURE in 4m 44s
✔️ ansible-tox-py38 SUCCESS in 5m 27s
✔️ ansible-tox-py39 SUCCESS in 4m 58s
✔️ ansible-tox-py310 SUCCESS in 5m 20s

@tremble tremble force-pushed the configure-importer branch from 49e13e8 to cb91a83 Compare June 28, 2022 11:22
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-tox-linters FAILURE in 4m 50s
✔️ ansible-tox-py38 SUCCESS in 4m 58s
✔️ ansible-tox-py39 SUCCESS in 5m 05s
✔️ ansible-tox-py310 SUCCESS in 4m 50s

@tremble tremble force-pushed the configure-importer branch from cb91a83 to 4ac5e70 Compare June 28, 2022 11:40
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 00s
✔️ ansible-tox-py38 SUCCESS in 4m 58s
✔️ ansible-tox-py39 SUCCESS in 5m 22s
✔️ ansible-tox-py310 SUCCESS in 4m 47s

@tremble tremble force-pushed the configure-importer branch from 4ac5e70 to 576d096 Compare June 28, 2022 11:52
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 39s
✔️ ansible-tox-py38 SUCCESS in 5m 08s
✔️ ansible-tox-py39 SUCCESS in 5m 13s
✔️ ansible-tox-py310 SUCCESS in 5m 06s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 43s
✔️ ansible-tox-py38 SUCCESS in 5m 31s
✔️ ansible-tox-py39 SUCCESS in 5m 46s
✔️ ansible-tox-py310 SUCCESS in 5m 19s

@tremble tremble force-pushed the configure-importer branch from c44dad6 to 7cf1d56 Compare June 28, 2022 12:51
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 52s
✔️ ansible-tox-py38 SUCCESS in 5m 09s
✔️ ansible-tox-py39 SUCCESS in 5m 04s
✔️ ansible-tox-py310 SUCCESS in 4m 59s

@tremble tremble force-pushed the configure-importer branch from 7cf1d56 to 350ea22 Compare June 28, 2022 13:48
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 34s
✔️ ansible-tox-py38 SUCCESS in 5m 22s
✔️ ansible-tox-py39 SUCCESS in 5m 53s
✔️ ansible-tox-py310 SUCCESS in 5m 22s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-tox-linters FAILURE in 6m 26s
✔️ ansible-tox-py38 SUCCESS in 5m 34s
✔️ ansible-tox-py39 SUCCESS in 5m 42s
✔️ ansible-tox-py310 SUCCESS in 5m 54s

@tremble tremble force-pushed the configure-importer branch from 71cab3e to 4c86a97 Compare June 28, 2022 14:26
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 6m 01s
✔️ ansible-tox-py38 SUCCESS in 6m 45s
✔️ ansible-tox-py39 SUCCESS in 6m 33s
✔️ ansible-tox-py310 SUCCESS in 6m 14s

@tremble tremble changed the title [WIP] Support configuring galaxy-importer Support configuring galaxy-importer Jun 28, 2022
@tremble
Copy link
Contributor Author

tremble commented Jun 28, 2022

@goneri This seems to be working - https://110f5add13e5d331fd47-d1950f745e803ba049ae07b9146c829d.ssl.cf5.rackcdn.com/1270/dc11d272467a50b3127618f19f23deca8b114db9/check/ansible-galaxy-importer/f01974f/job-output.txt

tremble
tremble commented Jun 28, 2022
View reviewed changes
playbooks/ansible-galaxy-importer/run.yaml
shell: "source .tox/venv/bin/activate; ./tools/validate-collection.sh ~/downloads/{{ galaxy_info.namespace}}-{{ galaxy_info.name }}-*.tar.gz"
shell: "source .tox/venv/bin/activate ; ./tools/validate-collection.sh ~/downloads/{{ galaxy_info.namespace}}-{{ galaxy_info.name }}-*.tar.gz"
environment:
GALAXY_IMPORTER_CONFIG: "/home/zuul/{{ zuul.project.src_dir }}/tests/galaxy-importer.cfg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: If the file is missing, galaxy importer ignores the missing file, this is safe even if collections don't include the config.

@goneri goneri added the mergeit Merge the PR (SoftwareFActory) label Jun 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 5m 35s
✔️ ansible-tox-py38 SUCCESS in 4m 58s
✔️ ansible-tox-py39 SUCCESS in 5m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit dc19f38 into ansible:master Jun 28, 2022
@tremble tremble mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFActory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @goneri