vmware_guest_disk: Use functions from module_utils #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariolenz
changed the title
|
@Akasurde @sky-joker @Tomorrow9 I have a feeling that I could have consolidated more code here. But I don't want to change too much in one PR. |
Thanks for reviewing @Tomorrow9! Since you approved and CI succeeded, I don't think I'll have to wait for a second opinion from @Akasurde or @sky-joker and will add the |
sky-joker
approved these changes
Jun 29, 2021
This was referenced Jul 1, 2021
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
Refactor vmware guest controller Depends-On: #967 SUMMARY Remove duplicate code from vmware_guest_controller by using functions from module_utils.vm_device_helper.PyVmomiDeviceHelper. Also, move some definitions from vmware_guest_controller and vmware_guest_disk to module_utils.vm_device_helper.PyVmomiDeviceHelper. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_controller vmware_guest_disk ADDITIONAL INFORMATION Follow-up to PR #914 Reviewed-by: Diane Wang <None> Reviewed-by: Mario Lenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove duplicate code from
vmware_guest_diskby using the functions frommodule_utils.vm_device_helper. PyVmomiDeviceHelper.ISSUE TYPE
COMPONENT NAME
vmware_guest_disk
ADDITIONAL INFORMATION
Follow-up to PR #909