Refactor vmware guest controller

[mariolenz]

Depends-On: #967

SUMMARY

Remove duplicate code from vmware_guest_controller by using functions from module_utils.vm_device_helper.PyVmomiDeviceHelper. Also, move some definitions from vmware_guest_controller and vmware_guest_disk to module_utils.vm_device_helper.PyVmomiDeviceHelper.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_guest_controller
vmware_guest_disk

ADDITIONAL INFORMATION

Follow-up to PR #914

[mariolenz]

recheck

[mariolenz]

recheck

[mariolenz]

I wonder why this didn't fail the CI...

Now that's weird. I see vmware_guest_controller in the list of targets in the log but I don't see it being actually run.

@Tomorrow9 Just for your information, I think that PR #936 has the same problem. It's possible that ansible/ansible-zuul-jobs#984 fixes this for now.

[mariolenz]

recheck

[mariolenz]

@Akasurde @goneri I don't see the integration tests for vmware_guest_controller or vmware_guest_disk in the log. Any ideas?

For your information, I've seen integration tests not being run several times during the last couple of days. I've opened issue #956 to track this.

[mariolenz]

recheck

[goneri]

@Akasurde @goneri I don't see the integration tests for vmware_guest_controller or vmware_guest_disk in the log. Any ideas?

For your information, I've seen integration tests not being run several times during the last couple of days. I've opened issue #956 to track this.

Thank you @mariolenz. I take a look.

[goneri]

recheck

[mariolenz]

recheck

[mariolenz]

recheck

[mariolenz]

Thanks for having a look at this PR @Tomorrow9! I've fixed the bug you found and will add the gate label now that the integration tests succeed.